| Message ID | 20171010093748.26927-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/4] FSP/CONSOLE: Do not associate unavailable console | expand |
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > Presently OPAL sends associate/unassociate MBOX command for all > FSP serial console (like below OPAL message). We have to check > console is available or not before sending this message. > > OPAL log: > ------- > [ 5013.227994012,7] FSP: Reassociating HVSI console 1 > [ 5013.227997540,7] FSP: Reassociating HVSI console 2 > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > Acked-by: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com> > --- > hw/fsp/fsp-console.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) Series merged to master as of d798c276b4da7559970702c2f31b12549c92741e 5.4.x as of 374fde2777647b8f78347c749630fb81d35bae24 and made it to 5.4.8. I made one minor change in that I'm resetting the timeout in the write path (when we write anything), just to make sure.
On 10/11/2017 02:32 PM, Stewart Smith wrote: > Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: >> Presently OPAL sends associate/unassociate MBOX command for all >> FSP serial console (like below OPAL message). We have to check >> console is available or not before sending this message. >> >> OPAL log: >> ------- >> [ 5013.227994012,7] FSP: Reassociating HVSI console 1 >> [ 5013.227997540,7] FSP: Reassociating HVSI console 2 >> >> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> >> Acked-by: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com> >> --- >> hw/fsp/fsp-console.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) > > Series merged to master as of d798c276b4da7559970702c2f31b12549c92741e > 5.4.x as of 374fde2777647b8f78347c749630fb81d35bae24 > and made it to 5.4.8. > > I made one minor change in that I'm resetting the timeout in the write > path (when we write anything), just to make sure. > I saw your changes. Looks ok to me. -Vasant
diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c index a855133..8ea4c16 100644 --- a/hw/fsp/fsp-console.c +++ b/hw/fsp/fsp-console.c @@ -92,6 +92,9 @@ static void fsp_console_reinit(void) for (i = 0; i < MAX_SERIAL; i++) { struct fsp_serial *fs = &fsp_serials[i]; + if (!fs->available) + continue; + if (fs->rsrc_id == 0xffff) continue; prlog(PR_DEBUG, "FSP: Reassociating HVSI console %d\n", i); @@ -903,6 +906,10 @@ static void reopen_all_hvsi(void) for (i = 0; i < MAX_SERIAL; i++) { struct fsp_serial *fs = &fsp_serials[i]; + + if (!fs->available) + continue; + if (fs->rsrc_id == 0xffff) continue; prlog(PR_NOTICE, "FSP: Deassociating HVSI console %d\n", i); @@ -911,6 +918,10 @@ static void reopen_all_hvsi(void) } for (i = 0; i < MAX_SERIAL; i++) { struct fsp_serial *fs = &fsp_serials[i]; + + if (!fs->available) + continue; + if (fs->rsrc_id == 0xffff) continue; prlog(PR_NOTICE, "FSP: Reassociating HVSI console %d\n", i);