Message ID | 20170803071808.7256-3-cyril.bur@au1.ibm.com |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xNLzf2HrWz9s72 for <incoming@patchwork.ozlabs.org>; Thu, 3 Aug 2017 17:19:58 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xNLzf0K1gzDrWP for <incoming@patchwork.ozlabs.org>; Thu, 3 Aug 2017 17:19:58 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xNLz00wVrzDrWn for <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:19:23 +1000 (AEST) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v737JFNA043534 for <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 03:19:21 -0400 Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) by mx0b-001b2d01.pphosted.com with ESMTP id 2c3xru9v70-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for <skiboot@lists.ozlabs.org>; Thu, 03 Aug 2017 03:19:20 -0400 Received: from localhost by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <skiboot@lists.ozlabs.org> from <cyril.bur@au1.ibm.com>; Thu, 3 Aug 2017 17:18:40 +1000 Received: from d23relay07.au.ibm.com (202.81.31.226) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 3 Aug 2017 17:18:38 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v737IcQO13107420 for <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:18:38 +1000 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v737Iato018231 for <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:18:36 +1000 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v737IaAU018225 for <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:18:36 +1000 Received: from camb691.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id BA6D0A013F for <skiboot@lists.ozlabs.org>; Thu, 3 Aug 2017 17:18:37 +1000 (AEST) From: Cyril Bur <cyril.bur@au1.ibm.com> To: skiboot@lists.ozlabs.org Date: Thu, 3 Aug 2017 17:17:59 +1000 X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170803071808.7256-1-cyril.bur@au1.ibm.com> References: <20170803071808.7256-1-cyril.bur@au1.ibm.com> X-TM-AS-MML: disable x-cbid: 17080307-0048-0000-0000-000002577BE1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17080307-0049-0000-0000-0000480A4672 Message-Id: <20170803071808.7256-3-cyril.bur@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-08-03_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708030112 Subject: [Skiboot] [PATCH v2 02/11] libflash/mbox-flash: Always close windows before opening a new window X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
diff --git a/libflash/mbox-flash.c b/libflash/mbox-flash.c index 7491d3b1..f9332415 100644 --- a/libflash/mbox-flash.c +++ b/libflash/mbox-flash.c @@ -617,6 +617,9 @@ static int mbox_window_move(struct mbox_flash_data *mbox_flash, goto out; } + mbox_flash->read.open = false; + mbox_flash->write.open = false; + rc = wait_for_bmc(mbox_flash, MBOX_DEFAULT_TIMEOUT); if (rc) { prlog(PR_ERR, "Error waiting for BMC\n");
The MBOX protocol states that if an open window command fails then all open windows are closed. Currently, if an open window command fails mbox-flash will erroneously assume that the previously open window is still open. The solution to this is to mark all windows as closed before issuing an open window command and then on success we'll mark the new window as open. Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> --- libflash/mbox-flash.c | 3 +++ 1 file changed, 3 insertions(+)