From patchwork Thu Jul 20 06:22:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Neuling X-Patchwork-Id: 791422 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xCkNz3mbyz9t2h for ; Thu, 20 Jul 2017 16:23:31 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xCkNz2dr9zDrFM for ; Thu, 20 Jul 2017 16:23:31 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xCkMr6CzmzDrF3 for ; Thu, 20 Jul 2017 16:22:32 +1000 (AEST) Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 3xCkMr4LKCz9t2w; Thu, 20 Jul 2017 16:22:32 +1000 (AEST) Received: by localhost.localdomain (Postfix, from userid 1000) id 8D1D0EEEDC7; Thu, 20 Jul 2017 16:22:32 +1000 (AEST) From: Michael Neuling To: stewart@linux.vnet.ibm.com Date: Thu, 20 Jul 2017 16:22:15 +1000 Message-Id: <20170720062220.14667-5-mikey@neuling.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170720062220.14667-1-mikey@neuling.org> References: <20170720062220.14667-1-mikey@neuling.org> Subject: [Skiboot] [PATCH 05/10] phb4: Fix endian of TLP headers print X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikey@neuling.org, skiboot@lists.ozlabs.org MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Byte swap TLP headers so they are the same as the PCIe spec. Also remove redundant print. Suggested-by: Rob Lippert Signed-off-by: Michael Neuling --- hw/phb4.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/phb4.c b/hw/phb4.c index cf9ee61871..6c3ca60ae2 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -203,12 +203,12 @@ static void phb4_eeh_dump_regs(struct phb4 *p) PHBERR(p, " uncorrErrorStatus = %08x\n", s->uncorrErrorStatus); PHBERR(p, " corrErrorStatus = %08x\n", s->corrErrorStatus); PHBERR(p, " uncorrErrorStatus = %08x\n", s->uncorrErrorStatus); - PHBERR(p, " tlpHdr1 = %08x\n", s->tlpHdr1); - PHBERR(p, " tlpHdr2 = %08x\n", s->tlpHdr2); - PHBERR(p, " tlpHdr3 = %08x\n", s->tlpHdr3); - PHBERR(p, " tlpHdr4 = %08x\n", s->tlpHdr4); + /* Byte swap TLP headers so they are the same as the PCIe spec */ + PHBERR(p, " tlpHdr1 = %08x\n", bswap_32(s->tlpHdr1)); + PHBERR(p, " tlpHdr2 = %08x\n", bswap_32(s->tlpHdr2)); + PHBERR(p, " tlpHdr3 = %08x\n", bswap_32(s->tlpHdr3)); + PHBERR(p, " tlpHdr4 = %08x\n", bswap_32(s->tlpHdr4)); PHBERR(p, " sourceId = %08x\n", s->sourceId); - PHBERR(p, " tlpHdr1 = %08x\n", s->tlpHdr1); PHBERR(p, " nFir = %016llx\n", s->nFir); PHBERR(p, " nFirMask = %016llx\n", s->nFirMask); PHBERR(p, " nFirWOF = %016llx\n", s->nFirWOF);