From patchwork Thu Jul 20 06:22:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Neuling X-Patchwork-Id: 791420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xCkNm0628z9t2J for ; Thu, 20 Jul 2017 16:23:20 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xCkNl6McFzDrFM for ; Thu, 20 Jul 2017 16:23:19 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xCkMr5lJJzDrDf for ; Thu, 20 Jul 2017 16:22:32 +1000 (AEST) Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 3xCkMr40Fwz9t2r; Thu, 20 Jul 2017 16:22:32 +1000 (AEST) Received: by localhost.localdomain (Postfix, from userid 1000) id 83766EEEDC4; Thu, 20 Jul 2017 16:22:32 +1000 (AEST) From: Michael Neuling To: stewart@linux.vnet.ibm.com Date: Thu, 20 Jul 2017 16:22:13 +1000 Message-Id: <20170720062220.14667-3-mikey@neuling.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170720062220.14667-1-mikey@neuling.org> References: <20170720062220.14667-1-mikey@neuling.org> Subject: [Skiboot] [PATCH 03/10] phb4: Better logs why the slot didn't work X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikey@neuling.org, skiboot@lists.ozlabs.org MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Better logs why the slot didn't work and make it a PR_ERR so users see it by default. Signed-off-by: Michael Neuling --- hw/phb4.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/phb4.c b/hw/phb4.c index 16304d52ac..48c591f4f3 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -2167,7 +2167,16 @@ static int64_t phb4_retry_state(struct pci_slot *slot) struct phb4 *p = phb_to_phb4(slot->phb); if (!slot->link_retries--) { - PHBERR(p, "Link detected but won't train\n"); + switch (slot->state) { + case PHB4_SLOT_LINK_WAIT_ELECTRICAL: + PHBERR(p, "Presence detected but no electrical link\n"); + break; + case PHB4_SLOT_LINK_WAIT: + PHBERR(p, "Electrical link detected but won't train\n"); + break; + default: + PHBERR(p, "Unknown link issue\n"); + } return OPAL_HARDWARE; }