diff mbox

[trivial] FSP/CHIPTOD: Return false in error path

Message ID 20170613104054.9632-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

Vasant Hegde June 13, 2017, 10:40 a.m. UTC
CC: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hw/fsp/fsp-chiptod.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stewart Smith June 14, 2017, 6:54 a.m. UTC | #1
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:
> CC: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> ---
>  hw/fsp/fsp-chiptod.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, merged to master as of 740d00b1036188c6e248418fb0a13faf14723e7a

Also merged to 5.4.x as of 84de6a50f49f4f4a0804ebd5f03189295d527186
diff mbox

Patch

diff --git a/hw/fsp/fsp-chiptod.c b/hw/fsp/fsp-chiptod.c
index 567f5df..7efad1b 100644
--- a/hw/fsp/fsp-chiptod.c
+++ b/hw/fsp/fsp-chiptod.c
@@ -57,6 +57,7 @@  static bool fsp_chiptod_update_topology(uint32_t cmd_sub_mod,
 		if (fsp_queue_msg(resp, fsp_freemsg)) {
 			fsp_freemsg(resp);
 			prerror("Failed to queue response msg\n");
+			return false;
 		}
 		return true;
 	default: