From patchwork Tue Jun 13 04:45:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasant Hegde X-Patchwork-Id: 774941 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wmxzm451bz9s8H for ; Tue, 13 Jun 2017 14:46:12 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wmxzm3MYdzDqL5 for ; Tue, 13 Jun 2017 14:46:12 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wmxzZ3l1yzDqL5 for ; Tue, 13 Jun 2017 14:46:02 +1000 (AEST) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5D4i7AP106779 for ; Tue, 13 Jun 2017 00:46:00 -0400 Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) by mx0b-001b2d01.pphosted.com with ESMTP id 2b28ta9aje-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 13 Jun 2017 00:45:59 -0400 Received: from localhost by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Jun 2017 14:45:56 +1000 Received: from d23relay07.au.ibm.com (202.81.31.226) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 13 Jun 2017 14:45:54 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v5D4jskA57409656 for ; Tue, 13 Jun 2017 14:45:54 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v5D4jrdc012472 for ; Tue, 13 Jun 2017 14:45:53 +1000 Received: from hegdevasant.in.ibm.com (hegdevasant.in.ibm.com [9.124.35.242]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v5D4jqYY012440; Tue, 13 Jun 2017 14:45:52 +1000 From: Vasant Hegde To: skiboot@lists.ozlabs.org Date: Tue, 13 Jun 2017 10:15:45 +0530 X-Mailer: git-send-email 2.9.3 X-TM-AS-MML: disable x-cbid: 17061304-0048-0000-0000-00000241DD42 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061304-0049-0000-0000-000047F1FF54 Message-Id: <20170613044545.25834-1-hegdevasant@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-13_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706130080 Subject: [Skiboot] [PATCH v2] FSP: Improve timeout message X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Presently we print word0 and word1 in error log. word0 contains sequence number and command class. One has to understand word0 format to identify command class. Lets explicitly print command class, sub command etc. CC: Ananth N Mavinakayanahalli Signed-off-by: Vasant Hegde Acked-by: Ananth N Mavinakayanahalli --- Changes in v2: Updated description. Note that we still have two messages in OPAL console and we log event to FSP after R/R completes. -Vasant hw/fsp/fsp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c index 162d9b4..4a8eaee 100644 --- a/hw/fsp/fsp.c +++ b/hw/fsp/fsp.c @@ -2168,8 +2168,8 @@ static void fsp_timeout_poll(void *data __unused) w1 = req->word1; mstate = req->state; prlog(PR_WARNING, "FSP: Response from FSP timed out," - " word0 = %x, word1 = %x state: %d\n", - w0, w1, mstate); + " cmd = %x subcmd = %x mod = %x state: %d\n", + w0 & 0xff, w1 & 0xff, (w1 >> 8) & 0xff, mstate); fsp_reg_dump(); fsp_cmdclass_resp_bitmask &= ~(1ull << index); cmdclass->timesent = 0; @@ -2180,8 +2180,9 @@ static void fsp_timeout_poll(void *data __unused) unlock(&fsp_lock); fsp_hir_reason_plid = log_simple_error( &e_info(OPAL_RC_FSP_POLL_TIMEOUT), - "FSP: Response from FSP timed out, word0 = %x," - "word1 = %x state: %d\n", w0, w1, mstate); + "FSP: Response from FSP timed out," + " cmd = %x subcmd = %x mod = %x state: %d\n", + w0 & 0xff, w1 & 0xff, (w1 >> 8) & 0xff, mstate); } next_bit: cmdclass_resp_bitmask = cmdclass_resp_bitmask >> 1;