diff mbox

[trivial] FSP/CONSOLE: Do not free fsp_msg in error path

Message ID 20170601043458.15644-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

Vasant Hegde June 1, 2017, 4:34 a.m. UTC 
.. as we reuse same msg to send next output message.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hw/fsp/fsp-console.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Stewart Smith June 8, 2017, 7:02 a.m. UTC | #1 
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:
> .. as we reuse same msg to send next output message.
>
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> ---
>  hw/fsp/fsp-console.c | 1 -
>  1 file changed, 1 deletion(-)

Pretty sure this is correct, merged as of 50c4c89c5dc0ae2a9adf0fc4cebbacb5cddac334
diff mbox

Patch

diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c
index 69c603a..8eaf7b8 100644
--- a/hw/fsp/fsp-console.c
+++ b/hw/fsp/fsp-console.c
@@ -145,7 +145,6 @@  static void fsp_pokemsg_reclaim(struct fsp_msg *msg)
 		if (fs->out_poke) {
 			if (fsp_queue_msg(fs->poke_msg, fsp_pokemsg_reclaim)) {
 				prerror("FSPCON: failed to queue poke msg\n");
-				fsp_freemsg(msg);
 			} else {
 				fs->out_poke = false;
 			}