From patchwork Wed Mar 15 09:58:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 739108 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vjpB75Xzfz9ryr for ; Wed, 15 Mar 2017 21:43:59 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vjpB74g5CzDqZS for ; Wed, 15 Mar 2017 21:43:59 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vjp9v3gfrzDqMd for ; Wed, 15 Mar 2017 21:43:47 +1100 (AEDT) Received: from pasglop.au.ibm.com (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v2F9x7Mg010085; Wed, 15 Mar 2017 04:59:32 -0500 From: Benjamin Herrenschmidt To: skiboot@lists.ozlabs.org Date: Wed, 15 Mar 2017 20:58:56 +1100 Message-Id: <20170315095900.13962-7-benh@kernel.crashing.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170315095900.13962-1-benh@kernel.crashing.org> References: <20170315095900.13962-1-benh@kernel.crashing.org> Subject: [Skiboot] [PATCH 07/11] phb4: Remove some unnecessary debug output X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" .. and update a comment while at it. Signed-off-by: Benjamin Herrenschmidt --- hw/phb4.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/phb4.c b/hw/phb4.c index 7117668..314e0f7 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -3034,8 +3034,6 @@ static int64_t phb4_dd1_lsi_set_xive(struct irq_source *is, uint32_t isn, struct phb4 *p = is->data; uint32_t idx = isn - p->base_lsi; - PHBERR(p, "DD1 LSI set_xive idx %d prio=%d\n", idx, priority); - if (idx > 8) return OPAL_PARAMETER; @@ -3045,16 +3043,17 @@ static int64_t phb4_dd1_lsi_set_xive(struct irq_source *is, uint32_t isn, /* Mask using P=0,Q=1, unmask using P=1,Q=0 followed by EOI */ /* XXX FIXME: A quick mask/umask can make us shoot an interrupt - * more than once to a queue. We need to keep track better + * more than once to a queue. We need to keep track better. + * + * Thankfully, this is only on DD1 and for LSIs, so will go away + * soon enough. */ - PHBERR(p, " LIST before: %016llx\n", in_be64(p->regs + PHB_IODA_DATA0)); if (priority == 0xff) out_be64(p->regs + PHB_IODA_DATA0, IODA3_LIST_Q); else { out_be64(p->regs + PHB_IODA_DATA0, IODA3_LIST_P); __irq_source_eoi(is, isn); } - PHBERR(p, " LIST after: %016llx\n", in_be64(p->regs + PHB_IODA_DATA0)); phb_unlock(&p->phb);