diff mbox

fsp-leds: add missing \n in duplicate loc code error msg

Message ID 20170309051531.17457-1-stewart@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

Stewart Smith March 9, 2017, 5:15 a.m. UTC 
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
 hw/fsp/fsp-leds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vasant Hegde March 9, 2017, 9:42 a.m. UTC | #1 
On 03/09/2017 10:45 AM, Stewart Smith wrote:
> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>

Thanks for fixing this. I think we are hitting few duplicate location code 
issues in P9 box. Will look into that next week.


Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

-Vasant

> ---
>   hw/fsp/fsp-leds.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c
> index b5a32addcb75..0fe0309494ba 100644
> --- a/hw/fsp/fsp-leds.c
> +++ b/hw/fsp/fsp-leds.c
> @@ -1585,7 +1585,7 @@ void create_led_device_nodes(void)
>   	list_for_each_safe(&cec_ledq, led, next, link) {
>   		/* Duplicate LED location code */
>   		if (dt_find_by_path(pled, led->loc_code)) {
> -			prlog(PR_WARNING, "duplicate location code %s",
> +			prlog(PR_WARNING, "duplicate location code %s\n",
>   			      led->loc_code);
>   			continue;
>   		}
>
Stewart Smith March 10, 2017, 12:28 a.m. UTC | #2 
Stewart Smith <stewart@linux.vnet.ibm.com> writes:
> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
> ---
>  hw/fsp/fsp-leds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

and merged to master as of 701617b1f6b12305aac88b71374f27b68f5a684e
diff mbox

Patch

diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c
index b5a32addcb75..0fe0309494ba 100644
--- a/hw/fsp/fsp-leds.c
+++ b/hw/fsp/fsp-leds.c
@@ -1585,7 +1585,7 @@  void create_led_device_nodes(void)
 	list_for_each_safe(&cec_ledq, led, next, link) {
 		/* Duplicate LED location code */
 		if (dt_find_by_path(pled, led->loc_code)) {
-			prlog(PR_WARNING, "duplicate location code %s",
+			prlog(PR_WARNING, "duplicate location code %s\n",
 			      led->loc_code);
 			continue;
 		}