diff mbox

phb4: Make MMIO0 BAR 256GB big

Message ID 20170301225428.25598-1-mikey@neuling.org
State Changes Requested
Headers show

Commit Message

Michael Neuling March 1, 2017, 10:54 p.m. UTC
Make MMIO0 BAR 256GB big.  This is to match a change in the global
MMIO map to allow for more GPUs to be attached.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
 hw/phb4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Benjamin Herrenschmidt March 1, 2017, 10:59 p.m. UTC | #1
On Thu, 2017-03-02 at 09:54 +1100, Michael Neuling wrote:
> diff --git a/hw/phb4.c b/hw/phb4.c
> index f4b5af3916..6a2f97b8a3 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -3264,7 +3264,7 @@ static void phb4_create(struct dt_node *np)
>  #define        ESB_BAR_BASE     0x000600c300000000ULL
>  #define        ESB_BAR_SIZE     0x0000000020000000ULL
>  #define        MMIO0_BAR_BASE   0x0006000000000000ULL
> -#define        MMIO0_BAR_SIZE   0x0000002000000000ULL
> +#define        MMIO0_BAR_SIZE   0x0000004000000000ULL
>  #define        MMIO1_BAR_BASE   0x000600c000000000ULL
>  #define        MMIO1_BAR_SIZE   0x0000000080000000ULL

NAK. Your MMIO0 is going to collide with MMIO1 on PHB 3 and above

Cheers,
Ben.
diff mbox

Patch

diff --git a/hw/phb4.c b/hw/phb4.c
index f4b5af3916..6a2f97b8a3 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -3264,7 +3264,7 @@  static void phb4_create(struct dt_node *np)
 #define	ESB_BAR_BASE     0x000600c300000000ULL
 #define	ESB_BAR_SIZE     0x0000000020000000ULL
 #define	MMIO0_BAR_BASE   0x0006000000000000ULL
-#define	MMIO0_BAR_SIZE   0x0000002000000000ULL
+#define	MMIO0_BAR_SIZE   0x0000004000000000ULL
 #define	MMIO1_BAR_BASE   0x000600c000000000ULL
 #define	MMIO1_BAR_SIZE   0x0000000080000000ULL