From patchwork Fri Dec 2 03:16:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sukadev Bhattiprolu X-Patchwork-Id: 701795 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tVKCG3XmMz9vDh for ; Fri, 2 Dec 2016 14:19:54 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tVKCG2B8zzDw2c for ; Fri, 2 Dec 2016 14:19:54 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tVK7n4t2MzDw33 for ; Fri, 2 Dec 2016 14:16:53 +1100 (AEDT) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uB23DeM6070213 for ; Thu, 1 Dec 2016 22:16:49 -0500 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0b-001b2d01.pphosted.com with ESMTP id 272xu7qc1e-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 01 Dec 2016 22:16:49 -0500 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Dec 2016 22:16:49 -0500 Received: from d01dlp02.pok.ibm.com (9.56.250.167) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 1 Dec 2016 22:16:46 -0500 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 95CC66E801D; Thu, 1 Dec 2016 22:16:19 -0500 (EST) Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uB23GiWP20644244; Fri, 2 Dec 2016 03:16:44 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E5379112054; Thu, 1 Dec 2016 22:16:43 -0500 (EST) Received: from suka-w540.localdomain (unknown [9.70.94.25]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP id ABAAD112034; Thu, 1 Dec 2016 22:16:43 -0500 (EST) Received: by suka-w540.localdomain (Postfix, from userid 1000) id 124D6221D41; Thu, 1 Dec 2016 19:16:41 -0800 (PST) Date: Thu, 1 Dec 2016 19:16:41 -0800 From: Sukadev Bhattiprolu To: Balbir Singh References: <1480484189-28133-1-git-send-email-sukadev@linux.vnet.ibm.com> <328bfeac-5c96-4c61-ed43-dfb82d637bf3@gmail.com> <20161130190627.GE5339@us.ibm.com> <20161201004657.GA17930@us.ibm.com> <28653688-7d65-7c8c-4551-49d4020cc051@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <28653688-7d65-7c8c-4551-49d4020cc051@gmail.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.7.1 (2016-10-04) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16120203-0056-0000-0000-00000219717B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006177; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000193; SDB=6.00788119; UDB=6.00381310; IPR=6.00565795; BA=6.00004935; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013510; XFM=3.00000011; UTC=2016-12-02 03:16:47 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16120203-0057-0000-0000-0000064C81FF Message-Id: <20161202031641.GD6855@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-12-02_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612020055 Subject: Re: [Skiboot] [PATCH v3 0/6] Enable basic VAS support X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hbabu@us.ibm.com, apopple@au1.ibm.com, skiboot list , Michael Neuling Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Balbir Singh [bsingharora@gmail.com] wrote: > > > On 01/12/16 11:46, Sukadev Bhattiprolu wrote: > > Oliver O'Halloran [oohall@gmail.com] wrote: > >> Half the reason we have the DT is to avoid having to guess about what > >> hardware is present based on things like the processor version. Is > >> there a compelling reason not to create a DT node? > > > > Not really. I was keeping the code minimal. Will add a patch on top of this > > set to create a device node for VAS under the xscom node. > > > > That sounds reasonable, but I think it would be nice to discuss the design > of the DT interface. I assume it won't be too late to revisit these patches then? With this change to my patchset: I get: # ls /proc/device-tree/xscom@603fc00000000/vas/ name phandle # od -xc /proc/device-tree/xscom@603fc00000000/vas/name 0000000 v a s \0 7661 7300 0000004 # od -xc /proc/device-tree/xscom@603fc00000000/vas/phandle 0000000 \0 \0 \0 $ 0000 0024 0000004 'vas' should show up under each chip of course. I can fold that change into one of my patches, but do we need to do anything else at this point? Thanks, Sukadev diff --git a/core/vas.c b/core/vas.c index 48d9505..9107e6b 100644 --- a/core/vas.c +++ b/core/vas.c @@ -372,6 +372,8 @@ static int init_one_chip(struct proc_chip *chip) if (alloc_irqs(chip)) goto out; + (void)dt_new(chip->devnode, "vas"); + prlog(PR_INFO, "VAS: Initialized chip %d\n", chip->id); return 0;