From patchwork Mon Jun 15 10:33:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ananth N Mavinakayanahalli X-Patchwork-Id: 484213 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A926714016A for ; Mon, 15 Jun 2015 20:34:26 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 90A8C1A0E70 for ; Mon, 15 Jun 2015 20:34:26 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id C56A61A0E4B for ; Mon, 15 Jun 2015 20:34:23 +1000 (AEST) Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Jun 2015 20:34:21 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 15 Jun 2015 20:34:18 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 67DE93578048 for ; Mon, 15 Jun 2015 20:34:18 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5FAY7Oh44302414 for ; Mon, 15 Jun 2015 20:34:16 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5FAXj8k006730 for ; Mon, 15 Jun 2015 20:33:45 +1000 Received: from thinktux.in.ibm.com (thinktux.in.ibm.com [9.124.31.67]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t5FAXibV006255 for ; Mon, 15 Jun 2015 20:33:44 +1000 From: Ananth N Mavinakayanahalli To: skiboot@lists.ozlabs.org Date: Mon, 15 Jun 2015 16:03:20 +0530 Message-ID: <20150615103320.28296.88348.stgit@thinktux.in.ibm.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15061510-0025-0000-0000-000001A7600C Subject: [Skiboot] [PATCH] [SURV] Fix surveillance locking X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" There is one instance of fsp_surv_state that is accessed without the surveillance lock. Fix it. Signed-off-by: Ananth N Mavinakayanahalli --- hw/fsp/fsp-surveillance.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/fsp/fsp-surveillance.c b/hw/fsp/fsp-surveillance.c index b94eb1b..18b2afd 100644 --- a/hw/fsp/fsp-surveillance.c +++ b/hw/fsp/fsp-surveillance.c @@ -192,8 +192,10 @@ static bool fsp_surv_msg_rr(u32 cmd_sub_mod, struct fsp_msg *msg) switch (cmd_sub_mod) { case FSP_RESET_START: printf("SURV: Disabling surveillance\n"); + lock(&surv_lock); fsp_surv_state = false; fsp_surv_ack_pending = false; + unlock(&surv_lock); return true; case FSP_RELOAD_COMPLETE: fsp_surv_query();