| Message ID | 1505973207-10195-1-git-send-email-maddy@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | skiboot/imc: Update the nest_pmus array with occ/gpe microcode uav updates | expand |
Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes: > OOC/gpe nest microcode maintains the list of individual nest units > supported. Sync the recent updates to the UAV with nest_pmus array. > > Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> > --- > Just for reference occ/gpr microcode link for the UAV: > https://github.com/open-power/occ/blob/master/src/occ_gpe1/gpe1_24x7.h I put the reference in with the commit message. I gather that the changes here occured because we brought in the IMC code around when they were still working on the ucode, and things hadn't quite stabilised then. You probably want to let them know that changing it going forward should use the reserved bits at the end rather than changing around what we have already. Merged as of 712837cedca06644d2e8dbb12e1cf535fbbd78ba
On Thursday 28 September 2017 10:16 AM, Stewart Smith wrote: > Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes: >> OOC/gpe nest microcode maintains the list of individual nest units >> supported. Sync the recent updates to the UAV with nest_pmus array. >> >> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> >> --- >> Just for reference occ/gpr microcode link for the UAV: >> https://github.com/open-power/occ/blob/master/src/occ_gpe1/gpe1_24x7.h > I put the reference in with the commit message. Want not sure. But yes its better. > > I gather that the changes here occured because we brought in the IMC > code around when they were still working on the ucode, and things hadn't > quite stabilised then. Exactly. thats right. > > You probably want to let them know that changing it going forward should > use the reserved bits at the end rather than changing around what we > have already. Yep have informed the same. Thanks for the review. Maddy > > Merged as of 712837cedca06644d2e8dbb12e1cf535fbbd78ba
diff --git a/hw/imc.c b/hw/imc.c index 99293ee36f9e..10505f69d4bd 100644 --- a/hw/imc.c +++ b/hw/imc.c @@ -60,7 +60,9 @@ char const *nest_pmus[] = { "phb0", "phb1", "phb2", - "resvd", + "phb3", + "phb4", + "phb5", "nx", "capp0", "capp1", @@ -69,13 +71,14 @@ char const *nest_pmus[] = { "alink0", "alink1", "alink2", + "alink3", "nvlink0", "nvlink1", "nvlink2", "nvlink3", "nvlink4", "nvlink5", - /* reserved bits : 48 - 64 */ + /* reserved bits : 51 - 63 */ }; /*
OOC/gpe nest microcode maintains the list of individual nest units supported. Sync the recent updates to the UAV with nest_pmus array. Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> --- Just for reference occ/gpr microcode link for the UAV: https://github.com/open-power/occ/blob/master/src/occ_gpe1/gpe1_24x7.h hw/imc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)