From patchwork Tue Apr 4 05:39:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ppaidipe X-Patchwork-Id: 746699 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vxyWS0lCYz9s7c for ; Tue, 4 Apr 2017 15:41:08 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vxyWS03Q8zDqJ8 for ; Tue, 4 Apr 2017 15:41:08 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vxyWK4m47zDq7c for ; Tue, 4 Apr 2017 15:41:01 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v345Xlw6056625 for ; Tue, 4 Apr 2017 01:40:58 -0400 Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) by mx0b-001b2d01.pphosted.com with ESMTP id 29kx8vs06f-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 04 Apr 2017 01:40:58 -0400 Received: from localhost by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Apr 2017 15:40:56 +1000 Received: from d23relay10.au.ibm.com (202.81.31.229) by e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 4 Apr 2017 15:40:53 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v345ejTm3473610 for ; Tue, 4 Apr 2017 15:40:53 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v345eHB7013469 for ; Tue, 4 Apr 2017 15:40:17 +1000 Received: from localhost.in.ibm.com ([9.124.31.19]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v345eGNX013314; Tue, 4 Apr 2017 15:40:16 +1000 From: Pridhiviraj Paidipeddi To: skiboot@lists.ozlabs.org Date: Tue, 4 Apr 2017 11:09:56 +0530 X-Mailer: git-send-email 2.7.4 X-TM-AS-MML: disable x-cbid: 17040405-0044-0000-0000-0000023F30D9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040405-0045-0000-0000-000006C53929 Message-Id: <1491284396-14381-1-git-send-email-ppaidipe@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-04-04_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704040051 Subject: [Skiboot] [PATCH] hw/occ: Log proper SCOM register names X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" This patch fixes the logging of incorrect SCOM register names. Signed-off-by: Pridhiviraj Paidipeddi --- hw/occ.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/occ.c b/hw/occ.c index ee76be6..7ea1922 100644 --- a/hw/occ.c +++ b/hw/occ.c @@ -399,7 +399,7 @@ static bool cpu_pstates_prepare_core(struct proc_chip *chip, struct cpu_thread * rc = xscom_read(chip->id, XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_PPMCR), &tmp); if (rc) { log_simple_error(&e_info(OPAL_RC_OCC_PSTATE_INIT), - "OCC: Failed to read from OCC in pstates init\n"); + "OCC: Failed to read PM_PPMCR from OCC in pstates init\n"); return false; } tmp = tmp & ~0xFFFF000000000000ULL; @@ -408,7 +408,7 @@ static bool cpu_pstates_prepare_core(struct proc_chip *chip, struct cpu_thread * rc = xscom_write(chip->id, XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_PPMCR), tmp); if (rc) { log_simple_error(&e_info(OPAL_RC_OCC_PSTATE_INIT), - "OCC: Failed to write PM_GP1 in pstates init\n"); + "OCC: Failed to write PM_PPMCR in pstates init\n"); return false; } time_wait_ms(1); /* Wait for PState to change */ @@ -435,7 +435,7 @@ static bool cpu_pstates_prepare_core(struct proc_chip *chip, struct cpu_thread * rc = xscom_read(chip->id, XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_PPMSR), &tmp); if (rc) { log_simple_error(&e_info(OPAL_RC_OCC_PSTATE_INIT), - "OCC: Failed to read back setting from OCC" + "OCC: Failed to read PM_PPMSR from OCC" "in pstates init\n"); return false; }