From patchwork Wed Dec 21 04:52:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 707642 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tk2P71j89z9t0q for ; Wed, 21 Dec 2016 15:54:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="G6W1yuAL"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tk2P70cjHzDwb7 for ; Wed, 21 Dec 2016 15:54:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="G6W1yuAL"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tk2Ms6gvFzDwXM for ; Wed, 21 Dec 2016 15:52:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="G6W1yuAL"; dkim-atps=neutral Received: by mail-pf0-x243.google.com with SMTP id i88so10166937pfk.2 for ; Tue, 20 Dec 2016 20:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rzv2ePIQQuwf6DKLup6Jd/lsvqYGIzstij35WaVSSuw=; b=G6W1yuALvObOkhMtWzbczGZKUgnsDgChDWkM8If9igSpMP48O7n0XIZlIDJtiJhHzl 4CCD4GejW6a79vLnmunv1TJPfaGWlzPYtBvWS+0p4BU6MUCWlaubB+L8Ly1vgQLCRuok fQV9eL3XOxxvqCbv14MjxMR6XFzr7cXNUDmZWJCs1R9Nxpo3UzRRj/BtbCyO445ZOdqb luqGKMIH2DTWjit+5ZWf825mc1/ehRjn5ukLMn4xUbWGy7zAxYN3kdqvqXKdLBbtkN8a dG1B6ghaHYGXVtIQZ8zPXrMIM93FGkRnkTblNpvVA+iIJV+Jw4ysXbc9qeSKwv0T5lVL BkWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rzv2ePIQQuwf6DKLup6Jd/lsvqYGIzstij35WaVSSuw=; b=qFVuKu18tFdf3Lkzxvy8mobEj7yr+aPVvUeT7y962K3yjtW1HzrYb9nd9keEnGWPTT p4ClnpkA9rbT1m3vL62oG/3e+psfSZ0UJCDFeV1+J4maH9YyFajQsAeHiH6pSUGFhwOC rwGFkoAFi+yrlJ1inZ/NPzt91pTJoMFvtfwiNzca8qf3T4azpIMEMdOztAaYljr0FTWx y0SL2UYCfwDf0ZG94fYRm9TtrmnmlHHghmCIp9/vMr4r/NqB/0z4NoLS9jIYTItO/VUA M3Nu6tv56TF4ZYzr87qi1lKFIS5eFVE9dZeA1j80XV4qWyyhoEF8RpZM0RV3MTP9nIgn cUzw== X-Gm-Message-State: AIkVDXJ+cnak59pSMWMn8T08bqWfKj+lMdMA6ZiDl1cGbjoQImxrtCOmG5C3hb96bLpKRQ== X-Received: by 10.84.225.132 with SMTP id u4mr5155806plj.93.1482295976316; Tue, 20 Dec 2016 20:52:56 -0800 (PST) Received: from flat-canetoad.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id 29sm1289001pfo.58.2016.12.20.20.52.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Dec 2016 20:52:56 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Wed, 21 Dec 2016 15:52:28 +1100 Message-Id: <1482295952-30060-7-git-send-email-oohall@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482295952-30060-1-git-send-email-oohall@gmail.com> References: <1482295952-30060-1-git-send-email-oohall@gmail.com> Subject: [Skiboot] [PATCH v3 06/10] console: document the dummy console X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" The OPAL console is normally completely independent to the internal skiboot console. The dummy console is atypical compared to the FSP and UART backends as it interacts with both consoles. This patch just adds a few comments to clarify the situation. Reviewed-by: Andrew Donnellan Signed-off-by: Oliver O'Halloran --- core/console.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/core/console.c b/core/console.c index bb0bdef13f7d..be5aa6211ce4 100644 --- a/core/console.c +++ b/core/console.c @@ -319,7 +319,12 @@ void memcons_add_properties(void) } /* - * Default OPAL console provided if nothing else overrides it + * The default OPAL console. + * + * In the absence of a "real" OPAL console driver we handle the OPAL_CONSOLE_* + * calls by writing into the skiboot log buffer. Reads are a little more + * complicated since they can come from the in-memory console (BML) or from the + * internal skiboot console driver. */ static int64_t dummy_console_write(int64_t term_number, int64_t *length, const uint8_t *buffer)