From patchwork Tue Dec 20 06:03:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 707326 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tjS8y4xhfz9t0w for ; Tue, 20 Dec 2016 17:11:30 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HuG5KNU6"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tjS8y3vK2zDwNB for ; Tue, 20 Dec 2016 17:11:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HuG5KNU6"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tjS0W3dxzzDwgK for ; Tue, 20 Dec 2016 17:04:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HuG5KNU6"; dkim-atps=neutral Received: by mail-pg0-x244.google.com with SMTP id w68so4683224pgw.3 for ; Mon, 19 Dec 2016 22:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1UccaRuUAWa4DecMtQCxM6Jx+K2yrrwlRb7qujXYjPQ=; b=HuG5KNU6LL780MBtEV5jdZfLJ+zpG09mW5EmAYs736eDwUE0FoDKkVax+kS9R9SCmz yLVPyUnyjEohkZb49FFWoOa7iDdLmeaGHRy6YBtoe9AKza4J8txqD8elmWDomcBqr8Eh 1Bvug624BPxityO5Xj7DEOHu3erto87IX83ko9TcoxEautbgP/BMT4U/1O+bj+xCiaTg 1pX4+bCIdYqwUEIOmM8kv/z7mcCV4B7MJzXKIjIyHbT2EuZEF7erFHjKS2jORWKGztmX ITVXBOAwMaHgQcCSCqRgez9srPqmq1yFqAUQtdjSjJyiIagsar40TICBQnT1nkXu6X/U zvog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1UccaRuUAWa4DecMtQCxM6Jx+K2yrrwlRb7qujXYjPQ=; b=d5/DLoFk/nWEqJ4ml1/v0Ag1KuETYikVv6RfE2N6WXSoinsspWjkI+BjQmJveZvzYR ZOdI27sM8Aw4I7K+V0Jo0MiQZ0Ma6/dJK3NOJIjUm8rwG2n/kxz1n+6TyXpcCodzK/vv 3KQBBMEG83ZlnaG+DN56xcp2XVkJN34oTyQTGm3g/5CgVkh4bHlsOos5B7dndqgWFnKt PHu9nnmRqwgIwVLhfaWMu63FcsJ7Daqf68JwtHzTgjDNPMuXRBD8arYuAb9pSjozJ2ko Qit8zZOPsanGOS3/uTbklYAy9jiyaYoyOyO8Ndwhe1k/ts2Le25ri4+WLAtBoMdb4L6Z 2Fqg== X-Gm-Message-State: AKaTC03U1jC6cyOjeJSR6DE7oWwT6BD4aYbshFEflhP3N7uYgXYYjzR6j+vn5Chs8Ps4CQ== X-Received: by 10.99.228.5 with SMTP id a5mr33974576pgi.1.1482213849593; Mon, 19 Dec 2016 22:04:09 -0800 (PST) Received: from flat-canetoad.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id u64sm28213696pgc.39.2016.12.19.22.04.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Dec 2016 22:04:09 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Tue, 20 Dec 2016 17:03:37 +1100 Message-Id: <1482213825-30448-7-git-send-email-oohall@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482213825-30448-1-git-send-email-oohall@gmail.com> References: <1482213825-30448-1-git-send-email-oohall@gmail.com> Subject: [Skiboot] [PATCH v2 06/14] console: document the dummy console X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" The OPAL console is normally completely independent to the internal skiboot console. The dummy console is atypical compared to the FSP and UART backends as it interacts with both consoles. This patch just adds a few comments to clarify the situation. Signed-off-by: Oliver O'Halloran Reviewed-by: Andrew Donnellan --- core/console.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/core/console.c b/core/console.c index bb0bdef13f7d..be5aa6211ce4 100644 --- a/core/console.c +++ b/core/console.c @@ -319,7 +319,12 @@ void memcons_add_properties(void) } /* - * Default OPAL console provided if nothing else overrides it + * The default OPAL console. + * + * In the absence of a "real" OPAL console driver we handle the OPAL_CONSOLE_* + * calls by writing into the skiboot log buffer. Reads are a little more + * complicated since they can come from the in-memory console (BML) or from the + * internal skiboot console driver. */ static int64_t dummy_console_write(int64_t term_number, int64_t *length, const uint8_t *buffer)