From patchwork Fri Dec 2 05:39:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 701808 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tVNJW6yhlz9t9b for ; Fri, 2 Dec 2016 16:39:39 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZhXbAifv"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tVNJW603FzDvnV for ; Fri, 2 Dec 2016 16:39:39 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZhXbAifv"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tVNJ66T1YzDvkH for ; Fri, 2 Dec 2016 16:39:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZhXbAifv"; dkim-atps=neutral Received: by mail-pf0-x243.google.com with SMTP id i88so3609924pfk.2 for ; Thu, 01 Dec 2016 21:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DGv0DCZ1Vc7OzgRjHtvQ2eB9o5CRrONRevFq826Lk/M=; b=ZhXbAifvtO8kLsVduWAzVmk/YIo0XVZRpQCUCtQFPtmH7FqU4lN1Ec+yCcv80knj/H 77yr6udnG9pL3ZM8FSsBYa3meGCb6i/GX4TWUhZtR/SmzqhgEjeWAEE/narrwgA9luvR cWlZgCDvrWa17KQeEu0Kdpo08k31rPaeFhLhG+/o/ZzyxSjR3yAOmV/TQqupbtMav2LC EpgOBXawa/9amjSn0WB0bNZx3e0UmaF9VzSnu9OcfBMPkfaqEZy3CdnbeM/gqxeoveJa nuNiWLK28rK7hSmjSYe4UVZaIuQo2OnWvgPHbqAtke2nUtGczRX4Yu6pl+kkWTeMwtWz CugA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DGv0DCZ1Vc7OzgRjHtvQ2eB9o5CRrONRevFq826Lk/M=; b=XCY2oyza6X0bRqONHIjPAq3MlT5nnteS/5IHUF0fCGidyzOtxvicfjknkMQ/6V1M16 gjkwvxBinvUIsBTgIozYe5wJexKkaVhQ0RKCVgd8wro6IIpUtn3lZihtl2bFwsib3ew2 2YEqyB/dOOAxcHDImTn49JpoVR7YLFod/7GP+vzqmJQuiHJ/GyPyz2hnF9ZoOEJEJ/iT N3nMQtDEIIzAEfrPe3BG56LrxDjozlDs4jSTgi7K+UHi99KTpV8JzGlhcFDX5msYPFSI vg5ku6p/8JoedQip1jamJUn9vzG3qRUOo5RLCs33OwSNAveqPxh4N8IJ7vKTZRwPnh2E aVoA== X-Gm-Message-State: AKaTC03aajT/gQfpzjxlHBFkwrSWaCZbkbraGt8EieWdtDV67H5Wa1T6ey67KEDiwG6u0w== X-Received: by 10.99.178.6 with SMTP id x6mr75662172pge.63.1480657157117; Thu, 01 Dec 2016 21:39:17 -0800 (PST) Received: from canetoad.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id r21sm4020332pfd.44.2016.12.01.21.39.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2016 21:39:16 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Fri, 2 Dec 2016 16:39:00 +1100 Message-Id: <1480657140-3955-3-git-send-email-oohall@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1480657140-3955-1-git-send-email-oohall@gmail.com> References: <1480657140-3955-1-git-send-email-oohall@gmail.com> Subject: [Skiboot] [PATCH 3/3] mambo_utils: add ascii output to hexdump X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Signed-off-by: Oliver O'Halloran --- external/mambo/mambo_utils.tcl | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/external/mambo/mambo_utils.tcl b/external/mambo/mambo_utils.tcl index 879db92528a8..d8825bc3cefb 100644 --- a/external/mambo/mambo_utils.tcl +++ b/external/mambo/mambo_utils.tcl @@ -155,7 +155,18 @@ proc hexdump { location count } { set val2 [format "%08x" [mysim memory display $val 4]] set val [expr $i + (4 * 3)] set val3 [format "%08x" [mysim memory display $val 4]] - set ascii "(none)" + + set ascii "" + for { set j 0 } { $j < 16 } { incr j } { + set byte [get_char [expr $i + $j]] + if { $byte < 0x20 || $byte >= 127} { + set c "." + } else { + set c [format %c $byte] + } + set ascii [string cat "$ascii" "$c"] + } + set loc [format "0x%016x" $i] puts "$loc: $val0 $val1 $val2 $val3 $ascii" }