From patchwork Wed Oct 12 02:31:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 680991 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3styXx5fJBz9sQw for ; Wed, 12 Oct 2016 13:31:29 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3styXx537rzDswx for ; Wed, 12 Oct 2016 13:31:29 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3styXq5bdDzDsrc for ; Wed, 12 Oct 2016 13:31:23 +1100 (AEDT) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9C2Ssgw008867 for ; Tue, 11 Oct 2016 22:31:20 -0400 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0b-001b2d01.pphosted.com with ESMTP id 2615buf80x-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 11 Oct 2016 22:31:20 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Oct 2016 20:31:18 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 11 Oct 2016 20:31:17 -0600 Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 2F4EB1FF0029 for ; Tue, 11 Oct 2016 20:30:57 -0600 (MDT) Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9C2VGWG14549482 for ; Wed, 12 Oct 2016 02:31:16 GMT Received: from localhost (unknown [127.0.0.1]) by IMSVA (Postfix) with SMTP id 248F8112040 for ; Tue, 11 Oct 2016 22:31:16 -0400 (EDT) X-IMSS-HAND-OFF-DIRECTIVE: 127.0.0.1:10026 Received: from birb.localdomain (unknown [9.185.16.52]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP id E1BF211205E; Tue, 11 Oct 2016 22:31:10 -0400 (EDT) Received: from ka1.ozlabs.ibm.com (localhost.localdomain [127.0.0.1]) by birb.localdomain (Postfix) with ESMTP id 3ED56229DB26; Wed, 12 Oct 2016 13:31:06 +1100 (AEDT) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Wed, 12 Oct 2016 13:31:04 +1100 X-Mailer: git-send-email 2.1.4 X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16101202-0020-0000-0000-000009FFA627 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005895; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000186; SDB=6.00767163; UDB=6.00367035; IPR=6.00543314; BA=6.00004801; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012955; XFM=3.00000011; UTC=2016-10-12 02:31:18 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16101202-0021-0000-0000-0000565E2304 Message-Id: <1476239464-20995-1-git-send-email-stewart@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-10-12_01:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610120039 Subject: [Skiboot] [PATCH] Declare proc_chip_quirks as extern, squash sparse warning X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" include/chip.h:134:3: warning: symbol 'proc_chip_quirks' was not declared. Should it be static? In fact it shouldn't be static, it should just exist *once* and that place is chip.c Signed-off-by: Stewart Smith --- include/chip.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/chip.h b/include/chip.h index 396e41f22df9..61b413ce97ba 100644 --- a/include/chip.h +++ b/include/chip.h @@ -131,7 +131,9 @@ enum proc_chip_quirks { QUIRK_SIMICS = 0x00000020, QUIRK_SLOW_SIM = 0x00000040, QUIRK_NO_DIRECT_CTL = 0x00000080, -} proc_chip_quirks; +}; + +extern enum proc_chip_quirks proc_chip_quirks; static inline bool chip_quirk(unsigned int q) {