| Message ID | 1476239464-20995-1-git-send-email-stewart@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
Stewart Smith <stewart@linux.vnet.ibm.com> writes: > include/chip.h:134:3: warning: symbol 'proc_chip_quirks' was not declared. Should it be static? > > In fact it shouldn't be static, it should just exist *once* and that > place is chip.c > > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> merged to master as of 53a786a7b4dfbd2f4a567c82e903ccf6745f3b74
diff --git a/include/chip.h b/include/chip.h index 396e41f22df9..61b413ce97ba 100644 --- a/include/chip.h +++ b/include/chip.h @@ -131,7 +131,9 @@ enum proc_chip_quirks { QUIRK_SIMICS = 0x00000020, QUIRK_SLOW_SIM = 0x00000040, QUIRK_NO_DIRECT_CTL = 0x00000080, -} proc_chip_quirks; +}; + +extern enum proc_chip_quirks proc_chip_quirks; static inline bool chip_quirk(unsigned int q) {
include/chip.h:134:3: warning: symbol 'proc_chip_quirks' was not declared. Should it be static? In fact it shouldn't be static, it should just exist *once* and that place is chip.c Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> --- include/chip.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)