From patchwork Mon Jul 25 00:44:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 652145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ryMvs18D8z9sCy for ; Mon, 25 Jul 2016 10:44:25 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=DkFoD7Wi; dkim-atps=neutral Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ryMvr73vfzDqcP for ; Mon, 25 Jul 2016 10:44:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=DkFoD7Wi; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mail-pa0-x243.google.com (mail-pa0-x243.google.com [IPv6:2607:f8b0:400e:c03::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ryMvm0hJ9zDqZn for ; Mon, 25 Jul 2016 10:44:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=DkFoD7Wi; dkim-atps=neutral Received: by mail-pa0-x243.google.com with SMTP id q2so10429447pap.0 for ; Sun, 24 Jul 2016 17:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=6tfXu6CF/aAs26eScJiQ3YdpI+aeWuESa/Bx1JBf1eo=; b=DkFoD7Wito4ork6Z+MMTUtdzd6KWdjKw1s6/9H1Tpqj0ML1s4Um5CTHQalX4XlcArP EiAQq9lsggr1G8BvUftgF4zJ53qTTQQcpZYAFbNJSo6Afze4m0OGvIVcFqv968uL5Gdz jyg85p/j2L2t/ULn2QPLdcDeKd/6LNJfrD1Hu96HoVcF2EpthQfDHuJXLj4x63U+QCCY aZ8iaS7O9WAeLSWy6o+djkPTa7q2flc/XX6jk71iznHIeiyaZ9p4dTC/lxFDTtappVMS siSJ2ydu7YcEk1Okq95GAwNJJyfKuznLJf4ah0FPqFNEIDfDOABGTItm0LHW7HX7fN0k uqtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6tfXu6CF/aAs26eScJiQ3YdpI+aeWuESa/Bx1JBf1eo=; b=hIRl9gdiNkhF5lyieZ0lQODFKvqYyYH8C2i6oYjkVXJEJt0PhNJgGlaOlbWq3pr/WC /+zegCTYGQnyo/wVHd24HBNUbbhDkwdQhudjgEbg/CZFz9Wz1yi+cCuJL2Ghwh0GRdFy PHjOQucZY1CDqmlUqzrihLoylRHSrV0gzUDIXVu1+QLymlCb2bFHrb3SadSwJGRrFxNZ UvYd3PeUkEgsD0OHPoF/vu+wv4m5wZGuz24SuT5aewMjMJKGCNhlZtewrWFznaQBwT29 0vCesskwBETc31gXfj2Zy0tCqGz8UcXn4cd+AwxAOxUxfOC6Bfuy8aJEjugDopeR9ZXu lafA== X-Gm-Message-State: AEkoouuhoVoFqXDle0q8/PklMaOjzQdyf3fCB1zEGOUecVV3Qi55Qkf3Qstf34/PG96F5A== X-Received: by 10.66.63.100 with SMTP id f4mr25187736pas.101.1469407455694; Sun, 24 Jul 2016 17:44:15 -0700 (PDT) Received: from canetoad.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id c82sm35058057pfb.72.2016.07.24.17.44.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jul 2016 17:44:15 -0700 (PDT) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Mon, 25 Jul 2016 10:44:03 +1000 Message-Id: <1469407443-31800-1-git-send-email-oohall@gmail.com> X-Mailer: git-send-email 2.5.5 Subject: [Skiboot] [PATCH] core/console: use char literals instead of numeric X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Save everyone a trip to asciitable.com. I realise everyone has probably memorised \n and friends, but THAT'S NOT THE POINT. Signed-off-by: Oliver O'Halloran Reviewed-by: Andrew Donnellan --- core/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/console.c b/core/console.c index e851fcf824a9..730ac245fd94 100644 --- a/core/console.c +++ b/core/console.c @@ -258,8 +258,8 @@ ssize_t console_write(bool flush_to_drivers, const void *buf, size_t count) while(count--) { char c = *(cbuf++); - if (c == 10) - write_char(13); + if (c == '\n') + write_char('\r'); write_char(c); }