diff mbox

[03/14] ipmi-sel: Add FWTS annotations for some errors

Message ID 1467005532-17667-4-git-send-email-stewart@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

Stewart Smith June 27, 2016, 5:32 a.m. UTC 
Namely around PNOR access requests and OCC reset.

Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
 hw/ipmi/ipmi-sel.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff mbox

Patch

diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
index 6bc386a8b24e..fa888a84d972 100644
--- a/hw/ipmi/ipmi-sel.c
+++ b/hw/ipmi/ipmi-sel.c
@@ -468,6 +468,12 @@  static void sel_pnor(uint8_t access)
 		occ_pnor_set_owner(PNOR_OWNER_HOST);
 		break;
 	default:
+		/**
+		 * @fwts-label InvalidPNORAccessRequest
+		 * @fwts-advice In negotiating PNOR access with BMC, we
+		 * got an odd/invalid request from the BMC. Likely a bug
+		 * in OPAL/BMC interaction.
+		 */
 		prlog(PR_ERR, "invalid PNOR access requested: %02x\n",
 		      access);
 	}
@@ -517,6 +523,10 @@  static void sel_occ_reset(uint8_t sensor)
 
 	rc = occ_sensor_id_to_chip(sensor, &chip);
 	if (rc) {
+		/**
+		 * @fwts-label: SELUnknownOCCReset
+		 * @fwts-advice: Likely bug in what sent us the OCC reset.
+		 */
 		prlog(PR_ERR, "SEL message to reset an unknown OCC "
 				"(sensor ID 0x%02x)\n", sensor);
 		return;