From patchwork Fri Jun 24 01:36:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 639976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rbLYc09nrz9s9Y for ; Fri, 24 Jun 2016 11:37:40 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3rbLYb6MjBzDqmZ for ; Fri, 24 Jun 2016 11:37:39 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rbLXv1rtNzDq5d for ; Fri, 24 Jun 2016 11:37:03 +1000 (AEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5O1YIRu024067 for ; Thu, 23 Jun 2016 21:37:01 -0400 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0a-001b2d01.pphosted.com with ESMTP id 23rskw2uft-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 23 Jun 2016 21:37:01 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Jun 2016 19:36:59 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 23 Jun 2016 19:36:54 -0600 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: stewart@linux.vnet.ibm.com Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 5CBBF19D801C for ; Thu, 23 Jun 2016 19:36:32 -0600 (MDT) Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5O1arhY46596276; Thu, 23 Jun 2016 18:36:53 -0700 Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B3D70C6037; Thu, 23 Jun 2016 19:36:53 -0600 (MDT) Received: from birb.localdomain (unknown [9.83.7.92]) by b03ledav006.gho.boulder.ibm.com (Postfix) with SMTP id 08C45C603C; Thu, 23 Jun 2016 19:36:52 -0600 (MDT) Received: from ka1.ozlabs.ibm.com (localhost.localdomain [127.0.0.1]) by birb.localdomain (Postfix) with ESMTP id 5E3F4229F46A; Fri, 24 Jun 2016 11:36:48 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Fri, 24 Jun 2016 11:36:44 +1000 X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466732206-23684-1-git-send-email-stewart@linux.vnet.ibm.com> References: <1466732206-23684-1-git-send-email-stewart@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062401-0008-0000-0000-000004E587A0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062401-0009-0000-0000-000038B08CA2 Message-Id: <1466732206-23684-3-git-send-email-stewart@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-06-23_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606240014 Subject: [Skiboot] [PATCH 3/5] fsp-epow: add FWTS annotation X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Signed-off-by: Stewart Smith --- hw/fsp/fsp-epow.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/fsp/fsp-epow.c b/hw/fsp/fsp-epow.c index df36c462a6b7..512a15c1cb3c 100644 --- a/hw/fsp/fsp-epow.c +++ b/hw/fsp/fsp-epow.c @@ -69,6 +69,10 @@ static void fsp_process_epow(struct fsp_msg *msg, int epow_type) /* Basic EPOW signature */ if (msg->data.bytes[0] != 0xF2) { + /** + * @fwts-label EPOWSignatureMismatch + * @fwts-advice Bug in skiboot/FSP code for EPOW event handling + */ prlog(PR_ERR, "Signature mismatch\n"); return; } @@ -105,6 +109,12 @@ static void fsp_process_epow(struct fsp_msg *msg, int epow_type) if (epow_changed) { rc = opal_queue_msg(OPAL_MSG_EPOW, NULL, NULL); if (rc) { + /** + * @fwts-label EPOWMessageQueueFailed + * @fwts-advice Queueing a message from OPAL to FSP + * failed. This is likely due to either an OPAL bug + * or the FSP going away. + */ prlog(PR_ERR, "OPAL EPOW message queuing failed\n"); return; }