From patchwork Fri Jun 24 01:36:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 639974 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rbLYM2jG3z9s9Y for ; Fri, 24 Jun 2016 11:37:27 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3rbLYM1sDwzDqmS for ; Fri, 24 Jun 2016 11:37:27 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rbLXs33ZXzDq5d for ; Fri, 24 Jun 2016 11:37:01 +1000 (AEST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5O1YLPm078236 for ; Thu, 23 Jun 2016 21:36:59 -0400 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0a-001b2d01.pphosted.com with ESMTP id 23rmkhvdms-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 23 Jun 2016 21:36:59 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Jun 2016 19:36:57 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 23 Jun 2016 19:36:53 -0600 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: stewart@linux.vnet.ibm.com Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 680771FF0045 for ; Thu, 23 Jun 2016 19:36:36 -0600 (MDT) Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5O1aqIu37945538; Thu, 23 Jun 2016 18:36:52 -0700 Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87E6FBE042; Thu, 23 Jun 2016 19:36:52 -0600 (MDT) Received: from birb.localdomain (unknown [9.83.7.92]) by b03ledav005.gho.boulder.ibm.com (Postfix) with SMTP id CFFFDBE03A; Thu, 23 Jun 2016 19:36:51 -0600 (MDT) Received: from ka1.ozlabs.ibm.com (localhost.localdomain [127.0.0.1]) by birb.localdomain (Postfix) with ESMTP id 75AEF229EAB0; Fri, 24 Jun 2016 11:36:47 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Fri, 24 Jun 2016 11:36:42 +1000 X-Mailer: git-send-email 2.1.4 X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062401-0016-0000-0000-000004078A11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062401-0017-0000-0000-0000307F574C Message-Id: <1466732206-23684-1-git-send-email-stewart@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-06-23_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606240014 Subject: [Skiboot] [PATCH 1/5] astbmc/common: add FWTS annotation X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Just one annotation here, pretty rare situation I think... but best to bail on this one, as this certainly isn't something we want in production. Signed-off-by: Stewart Smith --- platforms/astbmc/common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c index 1ed7d42dd836..d38de3ba48b6 100644 --- a/platforms/astbmc/common.c +++ b/platforms/astbmc/common.c @@ -78,6 +78,11 @@ static void astbmc_ipmi_setenables(void) msg = ipmi_mkmsg_simple(IPMI_SET_ENABLES, &data, sizeof(data)); if (!msg) { + /** + * @fwts-label ASTBMCFailedSetEnables + * @fwts-advice AST BMC is likely to be non-functional + * when accessed from host. + */ prlog(PR_ERR, "ASTBMC: failed to set enables\n"); return; }