| Message ID | 1453318291-22164-2-git-send-email-anoo@us.ibm.com |
|---|---|
| State | Superseded |
| Headers | show |
On 21/01/16 06:31, Adriana Kobylak wrote: > These 32MB chips are used in the Barreleye OpenBMC BMC. > > From: Adriana Kobylak <anoo@us.ibm.com> The From: line needs to go at the top of the patch for git to see it. If you use "git config" to set "user.name" and "user.email" to your IBM address so your commit is recorded accordingly, then I *think* git send-email should notice that and put in the From header for you (I might be wrong, I use the same account for my committer ID and my email, so I've never needed to do this). Other than that - thanks for addressing the other concerns, the coding style looks good now!
On 01/22/2016 08:15 AM, Andrew Donnellan wrote: > On 21/01/16 06:31, Adriana Kobylak wrote: >> These 32MB chips are used in the Barreleye OpenBMC BMC. >> >> From: Adriana Kobylak <anoo@us.ibm.com> > > The From: line needs to go at the top of the patch for git to see it. If you use > "git config" to set "user.name" and "user.email" to your IBM address so your > commit is recorded accordingly, then I *think* git send-email should notice that > and put in the From header for you (I might be wrong, I use the same account for > my committer ID and my email, so I've never needed to do this). Adriana, Also Signed-off-by is missing. I think once you make above changes then it will add automatically. Otherwise use commands like git commit -s .. it will add your s-o-b automatically. Go through submitting patch [1] documentation in kernel. It will help. [1]https://www.kernel.org/doc/Documentation/SubmittingPatches -Vasant
diff --git a/libflash/libflash.c b/libflash/libflash.c index 69e809e..929766e 100644 --- a/libflash/libflash.c +++ b/libflash/libflash.c @@ -31,12 +31,18 @@ static const struct flash_info flash_info[] = { { 0xc22019, 0x02000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix MXxxL25635F"}, { 0xc2201a, 0x04000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix MXxxL51235F"}, { 0xef4018, 0x01000000, FL_ERASE_ALL, "Winbond W25Q128BV" }, + { 0xef4019, 0x02000000, FL_ERASE_ALL | FL_ERASE_64K | FL_CAN_4B | + FL_ERASE_BULK, + "Winbond W25Q256BV"}, { 0x20ba20, 0x04000000, FL_ERASE_4K | FL_ERASE_64K | FL_CAN_4B | FL_ERASE_BULK | FL_MICRON_BUGS, "Micron N25Qx512Ax" }, { 0x20ba19, 0x02000000, FL_ERASE_4K | FL_ERASE_64K | FL_CAN_4B | FL_ERASE_BULK | FL_MICRON_BUGS, "Micron N25Q256Ax" }, + { 0x1940ef, 0x02000000, FL_ERASE_4K | FL_ERASE_64K | FL_CAN_4B | + FL_ERASE_BULK | FL_MICRON_BUGS, + "Micron N25Qx256Ax" }, { 0x4d5444, 0x02000000, FL_ERASE_ALL | FL_CAN_4B, "File Abstraction"}, { 0x55aa55, 0x00100000, FL_ERASE_ALL | FL_CAN_4B, "TEST_FLASH" }, { 0xaa55aa, 0x02000000, FL_ERASE_ALL | FL_CAN_4B, "EMULATED_FLASH"},
These 32MB chips are used in the Barreleye OpenBMC BMC. From: Adriana Kobylak <anoo@us.ibm.com> --- libflash/libflash.c | 6 ++++++ 1 file changed, 6 insertions(+)