From patchwork Mon Jul 20 09:01:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Kerr X-Patchwork-Id: 497605 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2C7F414077A for ; Mon, 20 Jul 2015 19:02:03 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 8162B1A0F08 for ; Mon, 20 Jul 2015 19:02:02 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id B83731A0A2F for ; Mon, 20 Jul 2015 19:01:47 +1000 (AEST) Received: by ozlabs.org (Postfix, from userid 1023) id 9C05F140D31; Mon, 20 Jul 2015 19:01:47 +1000 (AEST) MIME-Version: 1.0 Message-Id: <1437382901.87706.272012312602.3.gpush@pablo> In-Reply-To: <1437382901.86573.37557308684.0.gpush@pablo> To: skiboot@lists.ozlabs.org From: Jeremy Kerr Date: Mon, 20 Jul 2015 17:01:41 +0800 Subject: [Skiboot] [RFC, PATCH 3/4] core/mem_region: allow pre-existing reserved-memory nodes X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel M Crowell Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" If the HB device tree provides a top-level reserved-memory node, we'll abort(). We want to be able to handle a pre-populated reserved-memory node in a future change, so handle this case gracefully. Signed-off-by: Jeremy Kerr --- core/mem_region.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/core/mem_region.c b/core/mem_region.c index fede263..d7e797e 100644 --- a/core/mem_region.c +++ b/core/mem_region.c @@ -1016,10 +1016,13 @@ void mem_region_add_dt_reserved(void) mem_regions_finalised = true; /* establish top-level reservation node */ - node = dt_new(dt_root, "reserved-memory"); - dt_add_property_cells(node, "#address-cells", 2); - dt_add_property_cells(node, "#size-cells", 2); - dt_add_property(node, "ranges", NULL, 0); + node = dt_find_by_path(dt_root, "reserved-memory"); + if (!node) { + node = dt_new(dt_root, "reserved-memory"); + dt_add_property_cells(node, "#address-cells", 2); + dt_add_property_cells(node, "#size-cells", 2); + dt_add_property(node, "ranges", NULL, 0); + } /* First pass: calculate length of property data */ list_for_each(®ions, region, list) {