From patchwork Tue Apr 28 03:49:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 465346 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DF9414007D for ; Tue, 28 Apr 2015 13:49:17 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 36DB81A0789 for ; Tue, 28 Apr 2015 13:49:17 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40BD71A03AA for ; Tue, 28 Apr 2015 13:49:08 +1000 (AEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id t3S3n2j1029659 for ; Mon, 27 Apr 2015 22:49:03 -0500 Message-ID: <1430192941.16571.153.camel@kernel.crashing.org> From: Benjamin Herrenschmidt To: skiboot@lists.ozlabs.org Date: Tue, 28 Apr 2015 13:49:01 +1000 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Subject: [Skiboot] [PATCH] PHB3: Wait 1s, not 100ms, for PCIe electricals to train X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" The comment says 1s but we are really only waiting for 100ms and this isn't enough for some Altera FPGA cards it seems. Signed-off-by: Benjamin Herrenschmidt --- We probably want that in our next 810.xx drop as well as master... hw/phb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/phb3.c b/hw/phb3.c index 0172cb3..3f56fbc 100644 --- a/hw/phb3.c +++ b/hw/phb3.c @@ -2043,7 +2043,7 @@ static int64_t phb3_start_link_poll(struct phb3 *p) */ p->retries = PHB3_LINK_ELECTRICAL_RETRIES; p->state = PHB3_STATE_WAIT_LINK_ELECTRICAL; - return phb3_set_sm_timeout(p, msecs_to_tb(100)); + return phb3_set_sm_timeout(p, msecs_to_tb(1000)); } static int64_t phb3_sm_hot_reset(struct phb3 *p)