diff mbox

[19/25] sparse: libflash_debug is unused

Message ID 1424776479-13958-20-git-send-email-clg@fr.ibm.com
State Superseded
Headers show

Commit Message

Cédric Le Goater Feb. 24, 2015, 11:14 a.m. UTC 
Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
---
 libflash/libflash.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Joel Stanley Feb. 25, 2015, 1:08 a.m. UTC | #1 
On Tue, Feb 24, 2015 at 9:44 PM, Cédric Le Goater <clg@fr.ibm.com> wrote:
> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
> ---
>  libflash/libflash.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/libflash/libflash.c b/libflash/libflash.c
> index 5badbffde9a8..2cc89777caae 100644
> --- a/libflash/libflash.c
> +++ b/libflash/libflash.c
> @@ -40,8 +40,6 @@ struct flash_chip {
>         void                    *smart_buf;     /* Buffer for smart writes */
>  };
>
> -bool libflash_debug;

This is used when using libflash in userspace, eg. pflash and
opal-prd. If you want to avoid the warning then perhaps wrap it in
#ifndef __SKIBOOT__.

Cheers,

Joel

>  int fl_read_stat(struct spi_flash_ctrl *ct, uint8_t *stat)
>  {
>         return ct->cmd_rd(ct, CMD_RDSR, false, 0, stat, 1);
> --
> 1.7.10.4
>
> _______________________________________________
> Skiboot mailing list
> Skiboot@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
diff mbox

Patch

diff --git a/libflash/libflash.c b/libflash/libflash.c
index 5badbffde9a8..2cc89777caae 100644
--- a/libflash/libflash.c
+++ b/libflash/libflash.c
@@ -40,8 +40,6 @@  struct flash_chip {
 	void			*smart_buf;	/* Buffer for smart writes */
 };
 
-bool libflash_debug;
-
 int fl_read_stat(struct spi_flash_ctrl *ct, uint8_t *stat)
 {
 	return ct->cmd_rd(ct, CMD_RDSR, false, 0, stat, 1);