| Message ID | 1424776479-13958-15-git-send-email-clg@fr.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On 02/24/2015 04:44 PM, Cédric Le Goater wrote: > hw/fsp/fsp.c:920:13: warning: function 'fsp_fillmsg' with external linkage has definition I have not seen this warning in my box (Fedora 21).. But fix looks good. > > Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> -Vasant > --- > hw/fsp/fsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c > index 21926b6359fd..2755c1221be1 100644 > --- a/hw/fsp/fsp.c > +++ b/hw/fsp/fsp.c > @@ -917,7 +917,7 @@ static void __fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, > va_end(list); > } > > -extern void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u8 add_words, ...) > +void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u8 add_words, ...) > { > va_list list; > >
diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c index 21926b6359fd..2755c1221be1 100644 --- a/hw/fsp/fsp.c +++ b/hw/fsp/fsp.c @@ -917,7 +917,7 @@ static void __fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, va_end(list); } -extern void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u8 add_words, ...) +void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u8 add_words, ...) { va_list list;
hw/fsp/fsp.c:920:13: warning: function 'fsp_fillmsg' with external linkage has definition Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> --- hw/fsp/fsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)