| Message ID | 20190315164440.13209-1-fbarrat@linux.ibm.com |
|---|---|
| Headers | show |
| Series | opencapi hw procedure fixes for mixed mode | expand |
On 16/3/19 3:44 am, Frederic Barrat wrote: > A small series of fixes for opencapi. The first 2 will be needed for > mixed mode on witherspoon, and since they only affect > npu2-hw-procedures.c, it shouldn't conflict with Andrew's patchset. > > The last one is not really for mixed mode, but it's related to the > previous zcal patch: we have a potential issue if we have 2 opencapi > adapters on the same socket. For the benefit of the non-CAPI people on this list: "mixed mode" is our informal term for "having an OpenCAPI device and a NVLink device connected to the same CPU" rather than "having both hash and radix threads"... > > > Frederic Barrat (3): > npu2-hw-procedures: Don't set iovalid for opencapi devices > npu2-hw-procedures: Fix zcal in mixed opencapi and nvlink mode > npu2/hw-procedures: Fix parallel zcal for opencapi > > hw/npu2-hw-procedures.c | 34 +++++++++++++++++++++++++++++----- > hw/npu2-opencapi.c | 5 +++-- > include/npu2.h | 3 ++- > 3 files changed, 34 insertions(+), 8 deletions(-) >
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes: > On 16/3/19 3:44 am, Frederic Barrat wrote: >> A small series of fixes for opencapi. The first 2 will be needed for >> mixed mode on witherspoon, and since they only affect >> npu2-hw-procedures.c, it shouldn't conflict with Andrew's patchset. >> >> The last one is not really for mixed mode, but it's related to the >> previous zcal patch: we have a potential issue if we have 2 opencapi >> adapters on the same socket. > > For the benefit of the non-CAPI people on this list: "mixed mode" is our > informal term for "having an OpenCAPI device and a NVLink device > connected to the same CPU" rather than "having both hash and radix > threads"... I'm not quite sure where the scarcity for unique terms has come from, I'd suggest the TLA of NOT (NVLink and OpenCAPI Together), but since I'd need approval from Elon Musk for a new TLA, I won't.
Frederic Barrat <fbarrat@linux.ibm.com> writes: > A small series of fixes for opencapi. The first 2 will be needed for > mixed mode on witherspoon, and since they only affect > npu2-hw-procedures.c, it shouldn't conflict with Andrew's patchset. > > The last one is not really for mixed mode, but it's related to the > previous zcal patch: we have a potential issue if we have 2 opencapi > adapters on the same socket. > > > Frederic Barrat (3): > npu2-hw-procedures: Don't set iovalid for opencapi devices > npu2-hw-procedures: Fix zcal in mixed opencapi and nvlink mode > npu2/hw-procedures: Fix parallel zcal for opencapi > > hw/npu2-hw-procedures.c | 34 +++++++++++++++++++++++++++++----- > hw/npu2-opencapi.c | 5 +++-- > include/npu2.h | 3 ++- > 3 files changed, 34 insertions(+), 8 deletions(-) > Thanks! Merged to master as of 14a78d5c2e857fc52bd367584e0da4bd39a21ff8