mbox series

[0/3] Sparse warning fixes

Message ID 20181217072810.30160-1-stewart@linux.ibm.com
Headers show
Series Sparse warning fixes | expand

Message

Stewart Smith Dec. 17, 2018, 7:28 a.m. UTC 
I poked at what warnings were coming out of a build with sparse (i.e.
make C=1) and set myself up a jenkins job to help track them.

We start off with 813 or so warnings. These patches fix ~160 of them.

There shouldn't be any functional changes.

Stewart Smith (3):
  sparse: Make tree 'constant is so big' warning clean
  zz: platform_ocapi can be static
  zaius: zaius_ocapi can be static

 hw/capp.c                   |   4 +-
 hw/npu.c                    |   6 +-
 hw/npu2-hw-procedures.c     |  40 +++---
 hw/npu2-opencapi.c          |   4 +-
 hw/npu2.c                   |   4 +-
 hw/p7ioc-phb.c              |   6 +-
 hw/phb3.c                   | 244 ++++++++++++++++++------------------
 hw/phb4.c                   |  48 +++----
 hw/xscom.c                  |   4 +-
 include/npu-regs.h          |  48 +++----
 include/npu2-regs.h         |   2 +-
 include/opal-internal.h     |   2 +-
 include/pci-slot.h          |   2 +-
 include/stack.h             |   2 +-
 platforms/astbmc/common.c   |   2 +-
 platforms/astbmc/garrison.c |   4 +-
 platforms/astbmc/p8dnu.c    |   4 +-
 platforms/astbmc/zaius.c    |   4 +-
 platforms/ibm-fsp/zz.c      |   2 +-
 19 files changed, 216 insertions(+), 216 deletions(-)

Comments

Stewart Smith Jan. 18, 2019, 6:59 a.m. UTC | #1 
Stewart Smith <stewart@linux.ibm.com> writes:
> I poked at what warnings were coming out of a build with sparse (i.e.
> make C=1) and set myself up a jenkins job to help track them.
>
> We start off with 813 or so warnings. These patches fix ~160 of them.
>
> There shouldn't be any functional changes.
>
> Stewart Smith (3):
>   sparse: Make tree 'constant is so big' warning clean
>   zz: platform_ocapi can be static
>   zaius: zaius_ocapi can be static

Series merged to master as of ec65b9ab4c4c3cea80849a071615dd9def629201

I nixed one of the fixes for "constant is too big" because ancient
assembler something something and I'm not fighting with centos6 and old
gcc this time on a friday.