From patchwork Thu May 24 00:13:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Kennington X-Patchwork-Id: 919459 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40rqcr3lWtz9s1B for ; Thu, 24 May 2018 10:14:20 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="dmO4HVIn"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40rqcr1SRvzF1HF for ; Thu, 24 May 2018 10:14:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="dmO4HVIn"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=flex--wak.bounces.google.com (client-ip=2607:f8b0:400c:c05::24a; helo=mail-vk0-x24a.google.com; envelope-from=3zamgwwmkb8kbpzv33v0t.r317zxq3380x787.3e0pq7.36v@flex--wak.bounces.google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="dmO4HVIn"; dkim-atps=neutral Received: from mail-vk0-x24a.google.com (mail-vk0-x24a.google.com [IPv6:2607:f8b0:400c:c05::24a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40rqcj5g4mzF1Gj for ; Thu, 24 May 2018 10:14:07 +1000 (AEST) Received: by mail-vk0-x24a.google.com with SMTP id g134-v6so14365933vke.3 for ; Wed, 23 May 2018 17:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:date:message-id:subject:from:to:cc; bh=0hpwB93GbQ2PmHfDbNjHwHDH1j2CADR7eKihNtU0BiI=; b=dmO4HVIn0CVi5yxB5twmC8FaYjUhVutTVYIMd8ZoeooQUaWlW/AF3xiqQoAMZYQH8i wBddbunnbWHcQeBhV/gHjpgEXAnjpfOTXjMPjXXiWP/bZdnnDpmAHG9/mhj+oP/z640d nfEHsQDBXr41qj0RofGu81iOZ3fKa5pGhLJZJf+JdLnBXpQZdnJPlmr3YhLkcTA8DYt5 g2wQM1GpB5YlvuVnmPnXqvDd9+lpAFo+oP03X0n6k9FGffZsqcAlVcwYmJc4fwD8z64c 1UIRuboeEgERuSSPi8GS515HcOjEbd6NiLYJy/FKAyGTqRaj2c93asZrTVycxILS4EzF 1UFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc; bh=0hpwB93GbQ2PmHfDbNjHwHDH1j2CADR7eKihNtU0BiI=; b=Y8JACTWzpufmr2xm7Kc2J+fPH6E5+JDcnabE3xCu/F+ElOxWTk/Cq7ypz/P3ArNX1q ry36nTol74cbDIqwRKewVQB+hXvfst6GgPCjEi93jrHLf4gfnOTqbHHKsjLr5WZXFuGF WqNk9E/zO5vwHstVQTK1qs4VqEqRaG6udcGcUc8HJyydJn91+FZL5F22xhVTzjjnAHby 7XleJIfcI2SSM08tON8KWScr/FV6bGVAK4hgDDpE6oyL4rN5ZqRsoZdNUEYwiCwTXgbE yELv78R4fTBm2YLNxMUADGsM8x5Jvst3ahl8iFy+5hLUV503sUBXCVZ6gEWojUTJryoB 1hiQ== X-Gm-Message-State: ALKqPweDxCJITVLDCnvpj0EEtC2+YbE44fvAyI8uCW8e2rp1F1T68WmQ N6WttV99pdUDpPeK40VIBDHGOUqE5WlGQ9WzBa6AnM+ALXwK6kVlGGJ+9c/wV3LF5lrYNw8w8OB yg9DsXV0GHnB5aQRAwIjbBqP33zZRce2NvIuS6v+Ti0DDCdCYO8szITg9 X-Google-Smtp-Source: AB8JxZpiRoR/MGknImhMZ+8+BYOy+3HK298LQUYkojCALMrsuHJskU+llUVtwGFxbOmy5nMf0+NAa04= MIME-Version: 1.0 X-Received: by 2002:a1f:97cd:: with SMTP id z196-v6mr2196906vkd.14.1527120844404; Wed, 23 May 2018 17:14:04 -0700 (PDT) Date: Wed, 23 May 2018 17:13:26 -0700 Message-Id: <20180524001335.15457-1-wak@google.com> X-Mailer: git-send-email 2.17.0 From: "William A. Kennington III" To: skiboot@lists.ozlabs.org, alistair@popple.id.au, jk@ozlabs.org Subject: [Skiboot] [PATCH 0/9] ipmi-watchdog: Fixes for error handling and general cleanups X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" The current watchdog implementation doesn't do a good job of handling error cases when the BMC side restarts or crashes. This set of patches tries to improve the robustness of the ipmi watchdog code such that recovery happens when possible. This series also adds a patch which enables the watchdog for the KEXEC payload since the kernel being executed is guaranteed to support handling the watchdog. It also adds some general cleanups to the code that made the above easier to implement. William A. Kennington III (9): ipmi-watchdog: WD_POWER_CYCLE_ACTION -> WD_RESET_ACTION ipmi-watchdog: Make it possible to set DONT_STOP ipmi-watchdog: Don't reset the watchdog twice ipmi-watchdog: Don't disable at shutdown ipmi-watchdog: Add a flag to determine if we are still ticking ipmi-watchdog: The stop action should disable reset ipmi-watchdog: Simplify our completion function ipmi-watchdog: Support resetting the watchdog after set ipmi-watchdog: Support handling re-initialization hw/ipmi/ipmi-watchdog.c | 126 +++++++++++++++++++++++++++++++--------- 1 file changed, 98 insertions(+), 28 deletions(-)