diff mbox

rtc: use after free in pcf50633_rtc_probe()

Message ID alpine.DEB.2.00.0911161312140.12810@bicker
State Accepted, archived
Headers show

Commit Message

Dan Carpenter Nov. 18, 2009, 8:30 a.m. UTC
"rtc" is freed and then dereferenced on the next line.  This patch fixes 
that.

This is a resend.  I have been offline for the last few months so I may 
have missed a reply or something.  Not sure what the status was.

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>

Comments

Alessandro Zummo Nov. 18, 2009, 10:06 a.m. UTC | #1
On Wed, 18 Nov 2009 10:30:14 +0200 (SAST)
Dan Carpenter <error27@gmail.com> wrote:

> "rtc" is freed and then dereferenced on the next line.  This patch fixes 
> that.
> 
> This is a resend.  I have been offline for the last few months so I may 
> have missed a reply or something.  Not sure what the status was.
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>


 Acked-by: Alessandro Zummo <a.zummo@towertech.it>
diff mbox

Patch

--- orig/drivers/rtc/rtc-pcf50633.c	2009-07-17 16:21:52.000000000 +0300
+++ new/drivers/rtc/rtc-pcf50633.c	2009-07-17 16:22:56.000000000 +0300
@@ -291,8 +291,9 @@ 
 				&pcf50633_rtc_ops, THIS_MODULE);
 
 	if (IS_ERR(rtc->rtc_dev)) {
+		int ret =  PTR_ERR(rtc->rtc_dev);
 		kfree(rtc);
-		return PTR_ERR(rtc->rtc_dev);
+		return ret;
 	}
 
 	pcf50633_register_irq(rtc->pcf, PCF50633_IRQ_ALARM,