diff mbox

rtc-88pm80x: Delete an error message for a failed memory allocation in pm80x_rtc_probe()

Message ID 79e5d766-2e58-4cea-7812-ea45995873ac@users.sourceforge.net
State Rejected
Headers show

Commit Message

SF Markus Elfring May 16, 2017, 1:01 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 16 May 2017 14:54:13 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/rtc/rtc-88pm80x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox

Patch

diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c
index 466bf7f9a285..ae0e2561ecfa 100644
--- a/drivers/rtc/rtc-88pm80x.c
+++ b/drivers/rtc/rtc-88pm80x.c
@@ -266,10 +266,8 @@  static int pm80x_rtc_probe(struct platform_device *pdev)
 
 	if (!pdata) {
 		pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
-		if (!pdata) {
-			dev_err(&pdev->dev, "failed to allocate memory\n");
+		if (!pdata)
 			return -ENOMEM;
-		}
 	}
 
 	info =