| Message ID | 6d01148014a62d8d412790dc8442af40368c6f8f.1662190009.git.zhoubinbin@loongson.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | rtc: ls2x: Add support for the Loongson-2K/LS7A RTC | expand |
On Sat, 2022-09-03 at 17:34 +0800, Binbin Zhou wrote: > This is now supported, enable for Loongson-3 systems. > Other systems are unaffected. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > Cc: Huacai Chen <chenhuacai@kernel.org> > Cc: WANG Xuerui <git@xen0n.name> > Cc: loongarch@lists.linux.dev > --- > arch/loongarch/configs/loongson3_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/loongarch/configs/loongson3_defconfig > b/arch/loongarch/configs/loongson3_defconfig > index 4083d3051109..b240bc4e2021 100644 > --- a/arch/loongarch/configs/loongson3_defconfig > +++ b/arch/loongarch/configs/loongson3_defconfig > @@ -660,6 +660,7 @@ CONFIG_USB_GADGET=y > CONFIG_INFINIBAND=m > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_EFI=y > +CONFIG_RTC_DRV_LS2X=y We already have RTC_DRV_EFI=y, IIUC this means we leave LS7A RTC for the firmware to drive and operate it through EFI service. So is this really needed for LoongArch systems? And if we enable both RTC_DRV_EFI and RTC_DRV_LS2X, will some bad thing (a conflict) happen?
Hi, Ruoyao, On Sat, Sep 3, 2022 at 6:45 PM Xi Ruoyao <xry111@xry111.site> wrote: > > On Sat, 2022-09-03 at 17:34 +0800, Binbin Zhou wrote: > > This is now supported, enable for Loongson-3 systems. > > Other systems are unaffected. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > Cc: Huacai Chen <chenhuacai@kernel.org> > > Cc: WANG Xuerui <git@xen0n.name> > > Cc: loongarch@lists.linux.dev > > --- > > arch/loongarch/configs/loongson3_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/loongarch/configs/loongson3_defconfig > > b/arch/loongarch/configs/loongson3_defconfig > > index 4083d3051109..b240bc4e2021 100644 > > --- a/arch/loongarch/configs/loongson3_defconfig > > +++ b/arch/loongarch/configs/loongson3_defconfig > > @@ -660,6 +660,7 @@ CONFIG_USB_GADGET=y > > CONFIG_INFINIBAND=m > > CONFIG_RTC_CLASS=y > > CONFIG_RTC_DRV_EFI=y > > +CONFIG_RTC_DRV_LS2X=y > > We already have RTC_DRV_EFI=y, IIUC this means we leave LS7A RTC for the > firmware to drive and operate it through EFI service. So is this really > needed for LoongArch systems? And if we enable both RTC_DRV_EFI and > RTC_DRV_LS2X, will some bad thing (a conflict) happen? Don't worry, please. EFI RTC depends on EFI runtime, so we need an available RTC if EFI runtime is disabled (by command line or any other reasons). On the other hand, multi RTCs can perfectly co-exist, they will be rtc0 and rtc1 under sysfs and rtc0 is the default one. Huacai > > -- > Xi Ruoyao <xry111@xry111.site> > School of Aerospace Science and Technology, Xidian University >
diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/configs/loongson3_defconfig index 4083d3051109..b240bc4e2021 100644 --- a/arch/loongarch/configs/loongson3_defconfig +++ b/arch/loongarch/configs/loongson3_defconfig @@ -660,6 +660,7 @@ CONFIG_USB_GADGET=y CONFIG_INFINIBAND=m CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_EFI=y +CONFIG_RTC_DRV_LS2X=y CONFIG_DMADEVICES=y CONFIG_UIO=m CONFIG_UIO_PDRV_GENIRQ=m
This is now supported, enable for Loongson-3 systems. Other systems are unaffected. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: WANG Xuerui <git@xen0n.name> Cc: loongarch@lists.linux.dev --- arch/loongarch/configs/loongson3_defconfig | 1 + 1 file changed, 1 insertion(+)