From patchwork Wed Apr 6 09:16:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Ni X-Patchwork-Id: 90000 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pv0-f184.google.com (mail-pv0-f184.google.com [74.125.83.184]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id C691BB6EDF for ; Wed, 6 Apr 2011 19:41:04 +1000 (EST) Received: by pvf33 with SMTP id 33sf317709pvf.11 for ; Wed, 06 Apr 2011 02:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:x-beenthere:received-spf:x-pgp-universal:from :to:cc:date:subject:thread-topic:thread-index:message-id:references :in-reply-to:accept-language:x-ms-has-attach:x-ms-tnef-correlator :acceptlanguage:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-language:content-type; bh=XDNa/yfxGSGU9/wN3lODiERisxxpn3hxZZIk4I/w0kU=; b=x7I9GkYrpsuwvQrLp2Vq2v8XL2pvfoUL+q6uriNILO4jUGvYmhF98BbvBG/XRX5Se/ snuhoJfZTJZ2bpnrQu07DnOT2hWKFCC2CKw09X5ax6yLUQmgwEJ3H/Rog7/XmhFg3lu4 FclhjSw1hEzzChtEILldlxY5boNjcLysyOKJ0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:x-pgp-universal:from:to:cc:date:subject :thread-topic:thread-index:message-id:references:in-reply-to :accept-language:x-ms-has-attach:x-ms-tnef-correlator:acceptlanguage :mime-version:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-language:content-type; b=2OwiofmAbbwE0u5fk+uVJ97jUXqVp7WPoQ9XFuNYTyiN1uMzGY6VowHfzPXPnHKdqk 6bwNQv12s5SznMEJnaqXtCVxKRIN4RXRAG/NGhJJCl5jih06NypqcL5W+vw8Oas4s/tO x41t7IE++7Mry9yDiote+Ts0fcLLtiRkG8Al0= Received: by 10.143.5.12 with SMTP id h12mr107297wfi.22.1302081433569; Wed, 06 Apr 2011 02:17:13 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.142.156.18 with SMTP id d18ls754492wfe.3.p; Wed, 06 Apr 2011 02:17:12 -0700 (PDT) Received: by 10.142.248.18 with SMTP id v18mr638843wfh.50.1302081432019; Wed, 06 Apr 2011 02:17:12 -0700 (PDT) Received: by 10.142.248.18 with SMTP id v18mr638842wfh.50.1302081431991; Wed, 06 Apr 2011 02:17:11 -0700 (PDT) Received: from hqemgate04.nvidia.com (hqemgate04.nvidia.com [216.228.121.35]) by gmr-mx.google.com with ESMTPS id x35si459689wfd.4.2011.04.06.02.17.11 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2011 02:17:11 -0700 (PDT) Received-SPF: pass (google.com: domain of wni@nvidia.com designates 216.228.121.35 as permitted sender) client-ip=216.228.121.35; Received: from hqnvupgp07.nvidia.com (Not Verified[216.228.121.13]) by hqemgate04.nvidia.com id ; Wed, 06 Apr 2011 02:14:52 -0700 Received: from hqemhub02.nvidia.com ([172.17.108.22]) by hqnvupgp07.nvidia.com (PGP Universal service); Wed, 06 Apr 2011 02:16:52 -0700 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 06 Apr 2011 02:16:52 -0700 Received: from hkemhub01.nvidia.com (10.18.67.12) by hqemhub02.nvidia.com (172.20.150.31) with Microsoft SMTP Server (TLS) id 8.2.254.0; Wed, 6 Apr 2011 02:17:14 -0700 Received: from HKMAIL01.nvidia.com ([10.18.67.15]) by hkemhub01.nvidia.com ([10.18.67.12]) with mapi; Wed, 6 Apr 2011 17:16:48 +0800 From: Wei Ni To: "rtc-linux@googlegroups.com" , "linux-kernel@vger.kernel.org" , "a.zummo@towertech.it" CC: "linux-tegra@vger.kernel.org" Date: Wed, 6 Apr 2011 17:16:47 +0800 Subject: [rtc-linux] RE: [PATCH v9] mfd: tps6586x: add RTC driver for TI TPS6586x Thread-Topic: [PATCH v9] mfd: tps6586x: add RTC driver for TI TPS6586x Thread-Index: AcvtNB39IIBh9/dhQGOHgfiPDyC+wgHBy/Pw Message-ID: <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4A5@HKMAIL01.nvidia.com> References: <1301308615-6507-1-git-send-email-wni@nvidia.com> In-Reply-To: <1301308615-6507-1-git-send-email-wni@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-Original-Sender: wni@nvidia.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wni@nvidia.com designates 216.228.121.35 as permitted sender) smtp.mail=wni@nvidia.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Language: en-US Could anyone review this issue? Thanks Wei. -----Original Message----- From: Wei Ni Sent: Monday, March 28, 2011 6:37 PM To: rtc-linux@googlegroups.com; linux-kernel@vger.kernel.org; a.zummo@towertech.it Cc: linux-tegra@vger.kernel.org; Wei Ni Subject: [PATCH v9] mfd: tps6586x: add RTC driver for TI TPS6586x From: Wei Ni this driver supports setting of alarms, and reading/setting of time Signed-off-by: Wei Ni --- v9: check the enable_irq_wake/disable_irq_wake return value. fix these two function's fisrt paremeter, it should use "&pdev->dev" drivers/rtc/rtc-tps6586x.c | 18 ++++++++++++++---- 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index b891899..a3944a5 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -335,19 +335,29 @@ static int __devexit tps6586x_rtc_remove(struct platform_device *pdev) static int tps6586x_rtc_suspend(struct platform_device *pdev, pm_message_t state) { + int ret; struct tps6586x_rtc *rtc = dev_get_drvdata(&pdev->dev); - if (device_may_wakeup(pdev)) - enable_irq_wake(rtc->irq); + if (device_may_wakeup(&pdev->dev)) + ret = enable_irq_wake(rtc->irq); + + if (ret) + dev_warn(&pdev->dev, "enable irq wakeup failed.\n"); + return 0; } static int tps6586x_rtc_resume(struct platform_device *pdev) { + int ret; struct tps6586x_rtc *rtc = dev_get_drvdata(&pdev->dev); - if (device_may_wakeup(pdev)) - disable_irq_wake(rtc->irq); + if (device_may_wakeup(&pdev->dev)) + ret = disable_irq_wake(rtc->irq); + + if (ret) + dev_warn(&pdev->dev, "disable irq wakeup failed.\n"); + return 0; }