From patchwork Thu Jan 15 23:46:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dann frazier X-Patchwork-Id: 18886 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from mail-gx0-f56.google.com (mail-gx0-f56.google.com [209.85.217.56]) by ozlabs.org (Postfix) with ESMTP id 52CC5DE359 for ; Fri, 16 Jan 2009 10:47:17 +1100 (EST) Received: by mail-gx0-f56.google.com with SMTP id 16so1630654gxk.1 for ; Thu, 15 Jan 2009 15:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received :received:received:x-virus-scanned:received:received:received:from :to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; bh=3iiu1ZZYD7G38mxN4Gc6ttBf7X7vxo4yWQ4Ax9CqA98=; b=JoYCwbJN7zyaTUQwHsLTAzFZeyC6mex2m7wRFOJ7e/Sl8ugr3ifhpoHOSk3FwxsyFO 6WuX82iFUKF3OrJM0SFpGeouAEuzXLl5ZkyT08BdPPoA7F5aeZduWKhYEpSpbV1YOnrq cKOsgPCNiW6L8StkUwHf0BajOYXl0udUn6K+g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results :x-virus-scanned:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; b=Kk5eXH1g+E6F5CMtfFrnQ2kaZIif20Kbc0VwO10n3c1fY2b5qC2Rgl/gNQFNTYklwO 8xe5FxObfD+TF2Kz4E6wU6MBqbXC6ONHgDQ21aY+b7zVkh6w501XxAc+KisuPUqK8Dj+ Lihv9oidXgA8EbMP/CbeeoCfli6Vn93Jn/dFQ= Received: by 10.100.210.9 with SMTP id i9mr126297ang.19.1232063232916; Thu, 15 Jan 2009 15:47:12 -0800 (PST) Received: by 10.176.158.42 with SMTP id g42gr1816yqe.0; Thu, 15 Jan 2009 15:47:12 -0800 (PST) X-Sender: dannf@ldl.fc.hp.com X-Apparently-To: rtc-linux@googlegroups.com Received: by 10.90.79.12 with SMTP id c12mr1268366agb.11.1232063232489; Thu, 15 Jan 2009 15:47:12 -0800 (PST) Received: from g1t0028.austin.hp.com (g1t0028.austin.hp.com [15.216.28.35]) by mx.google.com with ESMTP id 39si18727yxd.3.2009.01.15.15.47.12; Thu, 15 Jan 2009 15:47:12 -0800 (PST) Received-SPF: pass (google.com: domain of dannf@ldl.fc.hp.com designates 15.216.28.35 as permitted sender) client-ip=15.216.28.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dannf@ldl.fc.hp.com designates 15.216.28.35 as permitted sender) smtp.mail=dannf@ldl.fc.hp.com Received: from g5t0029.atlanta.hp.com (g5t0029.atlanta.hp.com [16.228.8.141]) by g1t0028.austin.hp.com (Postfix) with ESMTP id 156DF1C22C; Thu, 15 Jan 2009 23:47:12 +0000 (UTC) Received: from ldl.fc.hp.com (ldl.fc.hp.com [15.11.146.30]) by g5t0029.atlanta.hp.com (Postfix) with ESMTP id A4C9D1002C; Thu, 15 Jan 2009 23:47:11 +0000 (UTC) Received: from localhost (ldl.fc.hp.com [127.0.0.1]) by ldl.fc.hp.com (Postfix) with ESMTP id 40C2E39C081; Thu, 15 Jan 2009 16:47:11 -0700 (MST) X-Virus-Scanned: Debian amavisd-new at ldl.fc.hp.com Received: from ldl.fc.hp.com ([127.0.0.1]) by localhost (ldl.fc.hp.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PeQS4W2GwUWn; Thu, 15 Jan 2009 16:47:07 -0700 (MST) Received: from krebs (krebs.dannf [10.8.0.7]) by ldl.fc.hp.com (Postfix) with ESMTP id 2F48839C07F; Thu, 15 Jan 2009 16:46:59 -0700 (MST) Received: by krebs (Postfix, from userid 20800) id 11B7C3B6923; Thu, 15 Jan 2009 16:46:58 -0700 (MST) From: dann frazier To: linux-parisc@vger.kernel.org, rtc-linux@googlegroups.com Cc: lkml@vger.kernel.org, kyle@mcmartin.ca, dann frazier Subject: [rtc-linux] [PATCH 8/9] remove a couple unnecessary variables Date: Thu, 15 Jan 2009 16:46:55 -0700 Message-Id: <628cabc357f25364e5c77e13c60b4c89b6f674a7.1231983599.git.dannf@hp.com> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <55691aea931c081791b3daa370e1eb961748cf78.1231983599.git.dannf@hp.com> References: <5bda6a81bf9fa4a3b60253bca73ef629a6ccc629.1231983599.git.dannf@hp.com> <0c29db565874aae3a60172ad42635fb8f60e8369.1231983599.git.dannf@hp.com> <0c2b8df6ecd123038e8458eeb9924b7959a707fa.1231983599.git.dannf@hp.com> <9b29163437fb37dc4996b17bcdb41192dbc79e9a.1231983599.git.dannf@hp.com> <8c4b31bbd7552995774e6b94db365d1f4b04f226.1231983599.git.dannf@hp.com> <55691aea931c081791b3daa370e1eb961748cf78.1231983599.git.dannf@hp.com> In-Reply-To: References: Reply-To: rtc-linux@googlegroups.com Sender: rtc-linux@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rtc-linux@googlegroups.com; contact rtc-linux+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rtc-linux@googlegroups.com X-BeenThere: rtc-linux@googlegroups.com Signed-off-by: dann frazier --- drivers/rtc/rtc-parisc.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-parisc.c b/drivers/rtc/rtc-parisc.c index a2ca07a..c29e918 100644 --- a/drivers/rtc/rtc-parisc.c +++ b/drivers/rtc/rtc-parisc.c @@ -25,11 +25,7 @@ static int parisc_get_time(struct device *dev, struct rtc_time *tm) static int parisc_set_time(struct device *dev, struct rtc_time *tm) { - int ret; - - ret = set_rtc_time(tm); - - if (ret < 0) + if (set_rtc_time(tm) < 0) return -EOPNOTSUPP; return 0; @@ -46,10 +42,8 @@ static int __init parisc_rtc_probe(struct platform_device *dev) p = rtc_device_register("rtc-parisc", &dev->dev, &parisc_rtc_ops, THIS_MODULE); - if (IS_ERR(p)) { - int err = PTR_ERR(p); - return err; - } + if (IS_ERR(p)) + return PTR_ERR(p); platform_set_drvdata(dev, p);