| Message ID | 4f2c049cb09d46fed336e22445c71988b4f340d6.1702962419.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: class: Remove usage of the deprecated ida_simple_xx() API | expand |
On Tue, 19 Dec 2023 06:07:12 +0100, Christophe JAILLET wrote: > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > This is less verbose. > > Applied, thanks! [1/1] rtc: class: Remove usage of the deprecated ida_simple_xx() API commit: e3d3fe7e7bf08820a83c9d9a4c38c7b29a2927f1 Best regards,
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index edfd942f8c54..921ee1827974 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c @@ -256,7 +256,7 @@ static int rtc_device_get_id(struct device *dev) of_id = of_alias_get_id(dev->parent->of_node, "rtc"); if (of_id >= 0) { - id = ida_simple_get(&rtc_ida, of_id, of_id + 1, GFP_KERNEL); + id = ida_alloc_range(&rtc_ida, of_id, of_id, GFP_KERNEL); if (id < 0) dev_warn(dev, "/aliases ID %d not available\n", of_id); }
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). This is less verbose. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Commit 592ff0c8d064 ("rtc: Directly use ida_alloc()/free()") missed this call --- drivers/rtc/class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)