| Message ID | 20240305080944.17991-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: rtc: abx80x: Improve checks on trickle charger constraints | expand |
On Tue, 05 Mar 2024 10:09:44 +0200, Laurent Pinchart wrote: > The abracon,tc-diode and abracon,tc-resistor DT properties are only > valid for the ABx0804 and ABx0805. Furthermore, they must both be > present, or neither of them must be specified. Add rules to check this. > > The generic abracon,abx08x compatible string doesn't indicate which chip > variant is used, but performs auto-detection at runtime. It must this > also allow the two above properties. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../bindings/rtc/abracon,abx80x.yaml | 25 ++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, 05 Mar 2024 10:09:44 +0200, Laurent Pinchart wrote: > The abracon,tc-diode and abracon,tc-resistor DT properties are only > valid for the ABx0804 and ABx0805. Furthermore, they must both be > present, or neither of them must be specified. Add rules to check this. > > The generic abracon,abx08x compatible string doesn't indicate which chip > variant is used, but performs auto-detection at runtime. It must this > also allow the two above properties. > > [...] Applied, thanks! [1/1] dt-bindings: rtc: abx80x: Improve checks on trickle charger constraints https://git.kernel.org/abelloni/c/32a6be085835 Best regards,
diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml index 58dbbca27deb..355b0598411a 100644 --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml @@ -9,9 +9,6 @@ title: Abracon ABX80X I2C ultra low power RTC/Alarm chip maintainers: - linux-rtc@vger.kernel.org -allOf: - - $ref: rtc.yaml# - properties: compatible: description: @@ -55,10 +52,32 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 enum: [0, 3, 6, 11] +dependentRequired: + abracon,tc-diode: ["abracon,tc-resistor"] + abracon,tc-resistor: ["abracon,tc-diode"] + required: - compatible - reg +allOf: + - $ref: rtc.yaml# + - if: + properties: + compatible: + not: + contains: + enum: + - abracon,abx80x + - abracon,ab0804 + - abracon,ab1804 + - abracon,ab0805 + - abracon,ab1805 + then: + properties: + abracon,tc-diode: false + abracon,tc-resistor: false + unevaluatedProperties: false examples:
The abracon,tc-diode and abracon,tc-resistor DT properties are only valid for the ABx0804 and ABx0805. Furthermore, they must both be present, or neither of them must be specified. Add rules to check this. The generic abracon,abx08x compatible string doesn't indicate which chip variant is used, but performs auto-detection at runtime. It must this also allow the two above properties. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .../bindings/rtc/abracon,abx80x.yaml | 25 ++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-)