[01/12] rtc: ds1511: drop useless checks

Message ID	20240227230431.1837717-1-alexandre.belloni@bootlin.com
State	Accepted
Headers	show Return-Path: <linux-rtc+bounces-738-incoming=patchwork.ozlabs.org@vger.kernel.org> From: alexandre.belloni@bootlin.com To: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/12] rtc: ds1511: drop useless checks Date: Wed, 28 Feb 2024 00:04:16 +0100 Message-ID: <20240227230431.1837717-1-alexandre.belloni@bootlin.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[01/12] rtc: ds1511: drop useless checks \| expand [01/12] rtc: ds1511: drop useless checks [02/12] rtc: ds1511: drop useless computation [03/12] rtc: ds1511: drop dead code [04/12] rtc: ds1511: drop useless enum [05/12] rtc: ds1511: fix function definition [06/12] rtc: ds1511: remove incomplete UIE support [07/12] rtc: ds1511: remove ds1511_rtc_update_alarm [08/12] rtc: ds1511: let the core know when alarm are not supported [09/12] rtc: ds1511: remove partial alarm support [10/12] rtc: ds1511: implement ds1511_rtc_read_alarm properly [11/12] rtc: ds1511: rename pdata [12/12] rtc: ds1511: drop inline/noinline hints

Message ID

20240227230431.1837717-1-alexandre.belloni@bootlin.com

State

Accepted

Headers

From: alexandre.belloni@bootlin.com
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 01/12] rtc: ds1511: drop useless checks
Date: Wed, 28 Feb 2024 00:04:16 +0100
Message-ID: <20240227230431.1837717-1-alexandre.belloni@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

[01/12] rtc: ds1511: drop useless checks | expand

Commit Message

Alexandre Belloni Feb. 27, 2024, 11:04 p.m. UTC

From: Alexandre Belloni <alexandre.belloni@bootlin.com>

The RTC core will always pass a valid rtc_tm, it is unnecessary to check
the validity of its members, especially with an open coded version of
rtc_valid_tm().

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-ds1511.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c
index 1109cad83838..87c52d20d31a 100644
--- a/drivers/rtc/rtc-ds1511.c
+++ b/drivers/rtc/rtc-ds1511.c
@@ -182,9 +182,6 @@  static int ds1511_rtc_set_time(struct device *dev, struct rtc_time *rtc_tm)
 	if (rtc_tm->tm_year < 1900)
 		rtc_tm->tm_year += 1900;
 
-	if (rtc_tm->tm_year < 1970)
-		return -EINVAL;
-
 	yrs = rtc_tm->tm_year % 100;
 	cen = rtc_tm->tm_year / 100;
 	mon = rtc_tm->tm_mon + 1;   /* tm_mon starts at zero */
@@ -194,15 +191,6 @@  static int ds1511_rtc_set_time(struct device *dev, struct rtc_time *rtc_tm)
 	min = rtc_tm->tm_min;
 	sec = rtc_tm->tm_sec;
 
-	if ((mon > 12) || (day == 0))
-		return -EINVAL;
-
-	if (day > rtc_month_days(rtc_tm->tm_mon, rtc_tm->tm_year))
-		return -EINVAL;
-
-	if ((hrs >= 24) || (min >= 60) || (sec >= 60))
-		return -EINVAL;
-
 	/*
 	 * each register is a different number of valid bits
 	 */

[01/12] rtc: ds1511: drop useless checks

Commit Message

Patch