| Message ID | 20240219091616.24480-1-antoniu.miclaus@analog.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: max31335: fix interrupt status reg | expand |
On Mon, 2024-02-19 at 11:16 +0200, Antoniu Miclaus wrote: > Fix the register value comparison in the `max31335_volatile_reg` > function for the interrupt status register. > > MAX31335_STATUS1 macro definition corresponds to the actual > interrupt status register. > > Fixes: dedaf03b99d6 ("rtc: max31335: add driver support") > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- Reviewed-by: Nuno Sa <nuno.sa@analog.com> > drivers/rtc/rtc-max31335.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c > index 402fda8fd548..a2441e5c2c74 100644 > --- a/drivers/rtc/rtc-max31335.c > +++ b/drivers/rtc/rtc-max31335.c > @@ -204,7 +204,7 @@ static bool max31335_volatile_reg(struct device *dev, unsigned > int reg) > return true; > > /* interrupt status register */ > - if (reg == MAX31335_INT_EN1_A1IE) > + if (reg == MAX31335_STATUS1) > return true; > > /* temperature registers */
On Mon, 19 Feb 2024 11:16:15 +0200, Antoniu Miclaus wrote: > Fix the register value comparison in the `max31335_volatile_reg` > function for the interrupt status register. > > MAX31335_STATUS1 macro definition corresponds to the actual > interrupt status register. > > > [...] I hope you realize that this is exactly what Guenter was referring to when he said: "It seems to be quite common for automotive chips, though, that they are held tightly under wrap, making it all but impossible to properly review their drivers. I have observed several times now that information not available to reviewers resulted in bad or buggy drivers." Applied [1/1] rtc: max31335: fix interrupt status reg https://git.kernel.org/abelloni/c/c12e67e076cb Best regards,
diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c index 402fda8fd548..a2441e5c2c74 100644 --- a/drivers/rtc/rtc-max31335.c +++ b/drivers/rtc/rtc-max31335.c @@ -204,7 +204,7 @@ static bool max31335_volatile_reg(struct device *dev, unsigned int reg) return true; /* interrupt status register */ - if (reg == MAX31335_INT_EN1_A1IE) + if (reg == MAX31335_STATUS1) return true; /* temperature registers */
Fix the register value comparison in the `max31335_volatile_reg` function for the interrupt status register. MAX31335_STATUS1 macro definition corresponds to the actual interrupt status register. Fixes: dedaf03b99d6 ("rtc: max31335: add driver support") Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/rtc/rtc-max31335.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)