diff mbox series

[1/2] rtc: max31335: remove unecessary locking

Message ID 20240115232215.273374-1-alexandre.belloni@bootlin.com
State Accepted
Headers show
Series [1/2] rtc: max31335: remove unecessary locking | expand

Commit Message

Alexandre Belloni Jan. 15, 2024, 11:22 p.m. UTC 
From: Alexandre Belloni <alexandre.belloni@bootlin.com>

There is no race condition when accessing MAX31335_STATUS1 because it is
always about clearing the alarm interrupt bit.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-max31335.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

Comments

Antoniu Miclaus Jan. 16, 2024, 10:47 a.m. UTC | #1 
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> There is no race condition when accessing MAX31335_STATUS1 because it is
> always about clearing the alarm interrupt bit.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  drivers/rtc/rtc-max31335.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
> index 3ddfe71bbb56..2ce23f60a7f3 100644
> --- a/drivers/rtc/rtc-max31335.c
> +++ b/drivers/rtc/rtc-max31335.c
> @@ -348,27 +348,19 @@ static int max31335_alarm_irq_enable(struct device
> *dev, unsigned int enabled)
>  static irqreturn_t max31335_handle_irq(int irq, void *dev_id)
>  {
>  	struct max31335_data *max31335 = dev_id;
> -	struct mutex *lock = &max31335->rtc->ops_lock;
>  	int ret, status;
> 
> -	mutex_lock(lock);
> -
>  	ret = regmap_read(max31335->regmap, MAX31335_STATUS1,
> &status);
>  	if (ret)
> -		goto exit;
> +		return IRQ_HANDLED;
> 
>  	if (FIELD_GET(MAX31335_STATUS1_A1F, status)) {
> -		ret = regmap_update_bits(max31335->regmap,
> MAX31335_STATUS1,
> -					 MAX31335_STATUS1_A1F, 0);
> -		if (ret)
> -			goto exit;
> +		regmap_update_bits(max31335->regmap,
> MAX31335_STATUS1,
> +				   MAX31335_STATUS1_A1F, 0);
> 
>  		rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF);
>  	}
> 
> -exit:
> -	mutex_unlock(lock);
> -
>  	return IRQ_HANDLED;
>  }
> 
> --
> 2.43.0
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
index 3ddfe71bbb56..2ce23f60a7f3 100644
--- a/drivers/rtc/rtc-max31335.c
+++ b/drivers/rtc/rtc-max31335.c
@@ -348,27 +348,19 @@  static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled)
 static irqreturn_t max31335_handle_irq(int irq, void *dev_id)
 {
 	struct max31335_data *max31335 = dev_id;
-	struct mutex *lock = &max31335->rtc->ops_lock;
 	int ret, status;
 
-	mutex_lock(lock);
-
 	ret = regmap_read(max31335->regmap, MAX31335_STATUS1, &status);
 	if (ret)
-		goto exit;
+		return IRQ_HANDLED;
 
 	if (FIELD_GET(MAX31335_STATUS1_A1F, status)) {
-		ret = regmap_update_bits(max31335->regmap, MAX31335_STATUS1,
-					 MAX31335_STATUS1_A1F, 0);
-		if (ret)
-			goto exit;
+		regmap_update_bits(max31335->regmap, MAX31335_STATUS1,
+				   MAX31335_STATUS1_A1F, 0);
 
 		rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF);
 	}
 
-exit:
-	mutex_unlock(lock);
-
 	return IRQ_HANDLED;
 }