| Message ID | 20230816113326.1468435-1-geert@linux-m68k.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() | expand |
On Wed, Aug 16, 2023, at 13:33, Geert Uytterhoeven wrote: > If CONFIG_PM_SLEEP=n (e.g. m68k/allmodconfig): > > drivers/rtc/rtc-stm32.c:904:12: error: ‘stm32_rtc_resume’ defined > but not used [-Werror=unused-function] > 904 | static int stm32_rtc_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~ > drivers/rtc/rtc-stm32.c:894:12: error: ‘stm32_rtc_suspend’ defined > but not used [-Werror=unused-function] > 894 | static int stm32_rtc_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~ > > Indeed, the previous change mixed up the semantics between > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and NOIRQ_SYSTEM_SLEEP_PM_OPS(). > Fix this by using the modern NOIRQ_SYSTEM_SLEEP_PM_OPS() instead. > > Reported-by: noreply@ellerman.id.au > Fixes: a69c610e13e2b2de ("rtc: stm32: remove incorrect #ifdef check") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 3ce4b3d08155b48d..76753c71d92eef3e 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -923,7 +923,7 @@ static int stm32_rtc_resume(struct device *dev) } static const struct dev_pm_ops stm32_rtc_pm_ops = { - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) + NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) }; static struct platform_driver stm32_rtc_driver = {
If CONFIG_PM_SLEEP=n (e.g. m68k/allmodconfig): drivers/rtc/rtc-stm32.c:904:12: error: ‘stm32_rtc_resume’ defined but not used [-Werror=unused-function] 904 | static int stm32_rtc_resume(struct device *dev) | ^~~~~~~~~~~~~~~~ drivers/rtc/rtc-stm32.c:894:12: error: ‘stm32_rtc_suspend’ defined but not used [-Werror=unused-function] 894 | static int stm32_rtc_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~ Indeed, the previous change mixed up the semantics between SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and NOIRQ_SYSTEM_SLEEP_PM_OPS(). Fix this by using the modern NOIRQ_SYSTEM_SLEEP_PM_OPS() instead. Reported-by: noreply@ellerman.id.au Fixes: a69c610e13e2b2de ("rtc: stm32: remove incorrect #ifdef check") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/rtc/rtc-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)