| Message ID | 20230725070429.383070-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: isl12026: Drop "_new" from probe callback name | expand |
On Tue, 25 Jul 2023 09:04:29 +0200, Uwe Kleine-König wrote: > The driver was introduced when .probe_new was the right probe callback > to use for i2c drivers. Today .probe is the right one (again) and the > driver was already switched in commit 31b0cecb4042 ("rtc: Switch i2c > drivers back to use .probe()") but the name continued to include "_new" > in its name. > > To prevent code readers wondering about what might be new here, drop > that irritating part of the name. > > [...] Applied, thanks! [1/1] rtc: isl12026: Drop "_new" from probe callback name commit: 58f3e83260a78cfd5648efa5448b237b9c230fc0 Best regards,
diff --git a/drivers/rtc/rtc-isl12026.c b/drivers/rtc/rtc-isl12026.c index 5abff5d348ac..634f4e7ee8aa 100644 --- a/drivers/rtc/rtc-isl12026.c +++ b/drivers/rtc/rtc-isl12026.c @@ -429,7 +429,7 @@ static void isl12026_force_power_modes(struct i2c_client *client) } } -static int isl12026_probe_new(struct i2c_client *client) +static int isl12026_probe(struct i2c_client *client) { struct isl12026 *priv; int ret; @@ -490,7 +490,7 @@ static struct i2c_driver isl12026_driver = { .name = "rtc-isl12026", .of_match_table = isl12026_dt_match, }, - .probe = isl12026_probe_new, + .probe = isl12026_probe, .remove = isl12026_remove, };
The driver was introduced when .probe_new was the right probe callback to use for i2c drivers. Today .probe is the right one (again) and the driver was already switched in commit 31b0cecb4042 ("rtc: Switch i2c drivers back to use .probe()") but the name continued to include "_new" in its name. To prevent code readers wondering about what might be new here, drop that irritating part of the name. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/rtc/rtc-isl12026.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 31b0cecb4042d2676fd48f09379a19bc8b16eadd