| Message ID | 20230424123522.18302-8-nikita.shubin@maquefel.me |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ep93xx device tree conversion | expand |
On 24/04/2023 15:34:23+0300, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > RTC block used in these SoCs. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > .../bindings/rtc/cirrus,ep93xx-rtc.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > new file mode 100644 > index 000000000000..d4774e984e7b > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml I guess this one should go in .Documentation/devicetree/bindings/rtc/trivial-rtc.yaml? > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus EP93xx Real Time Clock controller > + > +maintainers: > + - Hartley Sweeten <hsweeten@visionengravers.com> > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: cirrus,ep9301-rtc > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + rtc0: rtc@80920000 { > + compatible = "cirrus,ep9301-rtc"; > + reg = <0x80920000 0x100>; > + }; > + > -- > 2.39.2 >
On 24/04/2023 14:34, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > RTC block used in these SoCs. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > .../bindings/rtc/cirrus,ep93xx-rtc.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > new file mode 100644 > index 000000000000..d4774e984e7b > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus EP93xx Real Time Clock controller > + > +maintainers: > + - Hartley Sweeten <hsweeten@visionengravers.com> > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: cirrus,ep9301-rtc Why only one compatible? What about ep9307 and ep9312? The same question for your previous patch - timer. Anyway, if you want to keep it like that, then filename should match compatible. Or merge it into trivial-rtc like Alexandre suggested. Best regards, Krzysztof
On 28/04/2023 16:35, Nikita Shubin wrote: > On Tue, 2023-04-25 at 11:28 +0200, Krzysztof Kozlowski wrote: >> On 24/04/2023 14:34, Nikita Shubin wrote: >>> This adds device tree bindings for the Cirrus Logic EP93xx >>> RTC block used in these SoCs. >> >> Thank you for your patch. There is something to discuss/improve. >> >>> >>> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> >>> --- >>> .../bindings/rtc/cirrus,ep93xx-rtc.yaml | 32 >>> +++++++++++++++++++ >>> 1 file changed, 32 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- >>> rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- >>> rtc.yaml >>> new file mode 100644 >>> index 000000000000..d4774e984e7b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml >>> @@ -0,0 +1,32 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Cirrus EP93xx Real Time Clock controller >>> + >>> +maintainers: >>> + - Hartley Sweeten <hsweeten@visionengravers.com> >>> + - Alexander Sverdlin <alexander.sverdlin@gmail.com> >>> + >>> +properties: >>> + compatible: >>> + const: cirrus,ep9301-rtc >> >> Why only one compatible? What about ep9307 and ep9312? The same >> question >> for your previous patch - timer. >> >> Anyway, if you want to keep it like that, then filename should match >> compatible. Or merge it into trivial-rtc like Alexandre suggested. > > I think i should move it to trivial-rtc - there is no need for a > separate file. If you add missing compatibles, you won't be able to move it easily to trivial-rtc. Best regards, Krzysztof
On Tue, 2023-04-25 at 11:28 +0200, Krzysztof Kozlowski wrote: > On 24/04/2023 14:34, Nikita Shubin wrote: > > This adds device tree bindings for the Cirrus Logic EP93xx > > RTC block used in these SoCs. > > Thank you for your patch. There is something to discuss/improve. > > > > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > > --- > > .../bindings/rtc/cirrus,ep93xx-rtc.yaml | 32 > > +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- > > rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- > > rtc.yaml > > new file mode 100644 > > index 000000000000..d4774e984e7b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > > @@ -0,0 +1,32 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Cirrus EP93xx Real Time Clock controller > > + > > +maintainers: > > + - Hartley Sweeten <hsweeten@visionengravers.com> > > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > > + > > +properties: > > + compatible: > > + const: cirrus,ep9301-rtc > > Why only one compatible? What about ep9307 and ep9312? The same > question > for your previous patch - timer. > > Anyway, if you want to keep it like that, then filename should match > compatible. Or merge it into trivial-rtc like Alexandre suggested. I think i should move it to trivial-rtc - there is no need for a separate file. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml new file mode 100644 index 000000000000..d4774e984e7b --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml @@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cirrus EP93xx Real Time Clock controller + +maintainers: + - Hartley Sweeten <hsweeten@visionengravers.com> + - Alexander Sverdlin <alexander.sverdlin@gmail.com> + +properties: + compatible: + const: cirrus,ep9301-rtc + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + rtc0: rtc@80920000 { + compatible = "cirrus,ep9301-rtc"; + reg = <0x80920000 0x100>; + }; +
This adds device tree bindings for the Cirrus Logic EP93xx RTC block used in these SoCs. Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- .../bindings/rtc/cirrus,ep93xx-rtc.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml