| Message ID | 20230323085904.957999-1-d-gole@ti.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [V2] rtc: k3: handle errors while enabling wake irq | expand |
On Thu, 23 Mar 2023 14:29:04 +0530, Dhruva Gole wrote: > Due to the potential failure of enable_irq_wake(), it would be better to > return error if it fails. > > Applied, thanks! [1/1] rtc: k3: handle errors while enabling wake irq commit: d31d7300ebc0c43021ec48c0e6a3a427386f4617 Best regards,
diff --git a/drivers/rtc/rtc-ti-k3.c b/drivers/rtc/rtc-ti-k3.c index ba23163cc042..0d90fe923355 100644 --- a/drivers/rtc/rtc-ti-k3.c +++ b/drivers/rtc/rtc-ti-k3.c @@ -632,7 +632,8 @@ static int __maybe_unused ti_k3_rtc_suspend(struct device *dev) struct ti_k3_rtc *priv = dev_get_drvdata(dev); if (device_may_wakeup(dev)) - enable_irq_wake(priv->irq); + return enable_irq_wake(priv->irq); + return 0; }
Due to the potential failure of enable_irq_wake(), it would be better to return error if it fails. Fixes: b09d633575e5 ("rtc: Introduce ti-k3-rtc") Cc: Nishanth Menon <nm@ti.com> Signed-off-by: Dhruva Gole <d-gole@ti.com> --- Changelog: Address the comments from Alexandre Belloni V1 link: https://lore.kernel.org/linux-rtc/20230323081942.951542-1-d-gole@ti.com drivers/rtc/rtc-ti-k3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)