| Message ID | 20230213041535.12083-4-rdunlap@infradead.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | IRQ_DOMAIN: remove all "depends on", use only "select" | expand |
Il 13/02/23 05:15, Randy Dunlap ha scritto: > IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set > it directly thru "make *config", so drivers should select it instead > of depending on it if they need it. > Relying on it being set for a dependency is risky. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on" for IRQ_DOMAIN to > "select" for RTC_DRV_MT6397. > > Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Eddie Huang <eddie.huang@mediatek.com> > Cc: Sean Wang <sean.wang@mediatek.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: Alessandro Zummo <a.zummo@towertech.it> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: linux-rtc@vger.kernel.org > Cc: Marc Zyngier <maz@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Peter Rosin <peda@axentia.se> > --- > I have a similar patch (should be a series) for REGMAP. > > drivers/rtc/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1814,7 +1814,8 @@ config RTC_DRV_MT2712 config RTC_DRV_MT6397 tristate "MediaTek PMIC based RTC" - depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN) + depends on MFD_MT6397 || COMPILE_TEST + select IRQ_DOMAIN help This selects the MediaTek(R) RTC driver. RTC is part of MediaTek MT6397 PMIC. You should enable MT6397 PMIC MFD before select
IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on" for IRQ_DOMAIN to "select" for RTC_DRV_MT6397. Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Eddie Huang <eddie.huang@mediatek.com> Cc: Sean Wang <sean.wang@mediatek.com> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: linux-rtc@vger.kernel.org Cc: Marc Zyngier <maz@kernel.org> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Peter Rosin <peda@axentia.se> --- I have a similar patch (should be a series) for REGMAP. drivers/rtc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)