| Message ID | 20230202155448.6715-7-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: pm8xxx: add support for setting time using nvmem | expand |
On 2/2/23 07:54, Johan Hovold wrote: > Drop the original register defines which have been used since commit s/used/unused/ > c8d523a4b053 ("drivers/rtc/rtc-pm8xxx.c: rework to support pm8941 rtc"). > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/rtc/rtc-pm8xxx.c | 6 ------ > 1 file changed, 6 deletions(-) Assuming that the minor commit text comment above is addressed: Reviewed-by: David Collins <quic_collinsd@quicinc.com> Take care, David
On Mon, Feb 06, 2023 at 07:15:02PM -0800, David Collins wrote: > On 2/2/23 07:54, Johan Hovold wrote: > > Drop the original register defines which have been used since commit > > s/used/unused/ Good catch. Perhaps Alexandre can amend the commit message when applying. It should be clear from Subject and the diff that this was a typo so I don't think this alone is worth resending the series for. > > c8d523a4b053 ("drivers/rtc/rtc-pm8xxx.c: rework to support pm8941 rtc"). > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > drivers/rtc/rtc-pm8xxx.c | 6 ------ > > 1 file changed, 6 deletions(-) > > Assuming that the minor commit text comment above is addressed: > > Reviewed-by: David Collins <quic_collinsd@quicinc.com> Johan
diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index dc7e659cbb2a..90027a7cfb12 100644 --- a/drivers/rtc/rtc-pm8xxx.c +++ b/drivers/rtc/rtc-pm8xxx.c @@ -12,12 +12,6 @@ #include <linux/slab.h> #include <linux/spinlock.h> -/* RTC Register offsets from RTC CTRL REG */ -#define PM8XXX_ALARM_CTRL_OFFSET 0x01 -#define PM8XXX_RTC_WRITE_OFFSET 0x02 -#define PM8XXX_RTC_READ_OFFSET 0x06 -#define PM8XXX_ALARM_RW_OFFSET 0x0A - /* RTC_CTRL register bit fields */ #define PM8xxx_RTC_ENABLE BIT(7) #define PM8xxx_RTC_ALARM_CLEAR BIT(0)
Drop the original register defines which have been used since commit c8d523a4b053 ("drivers/rtc/rtc-pm8xxx.c: rework to support pm8941 rtc"). Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/rtc/rtc-pm8xxx.c | 6 ------ 1 file changed, 6 deletions(-)