| Message ID | 20230111163404.3526248-2-w.egorov@phytec.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] dt-bindings: leds: Convert PCA9532 to dtschema | expand |
On Wed, Jan 11, 2023 at 05:34:04PM +0100, Wadim Egorov wrote: > Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml. That's obvious from the diff. What's not obvious is 'why' and the commit message should answer that. I assume something about it makes it not trivial. > > Signed-off-by: Wadim Egorov <w.egorov@phytec.de> > --- > v2: > - Update subject > - Remove not needed quotes > - Remove start-year > - Use unevaluatedProperties instead of additionalProperties > --- > .../bindings/rtc/microcrystal,rv3028.yaml | 54 +++++++++++++++++++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > 2 files changed, 54 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml Otherwise, Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, 11 Jan 2023 17:34:04 +0100, Wadim Egorov wrote: > Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml. > > Applied, thanks! [2/2] dt-bindings: rtc: Move rv3028 from trivial-rtc.yaml into own schema file commit: c690048ed59b5f7df91899507f210ba6591c0d8f Best regards,
diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml new file mode 100644 index 000000000000..5ade5dfad048 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip RV-3028 RTC + +allOf: + - $ref: rtc.yaml# + +maintainers: + - Alexandre Belloni <alexandre.belloni@bootlin.com> + +properties: + compatible: + const: microcrystal,rv3028 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + trickle-resistor-ohms: + enum: + - 3000 + - 5000 + - 9000 + - 15000 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rtc@51 { + compatible = "microcrystal,rv3028"; + reg = <0x51>; + pinctrl-0 = <&rtc_nint_pins>; + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>; + trickle-resistor-ohms = <3000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml index d9fc120c61cc..84cce1f0ca0c 100644 --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml @@ -48,8 +48,6 @@ properties: # Intersil ISL12022 Real-time Clock - isil,isl12022 # Real Time Clock Module with I2C-Bus - - microcrystal,rv3028 - # Real Time Clock Module with I2C-Bus - microcrystal,rv3029 # Real Time Clock - microcrystal,rv8523
Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml. Signed-off-by: Wadim Egorov <w.egorov@phytec.de> --- v2: - Update subject - Remove not needed quotes - Remove start-year - Use unevaluatedProperties instead of additionalProperties --- .../bindings/rtc/microcrystal,rv3028.yaml | 54 +++++++++++++++++++ .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - 2 files changed, 54 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml