[v3,14/14] dt-bindings: rtc: pcf2127: add PCF2131

Message ID	20221215150214.1109074-15-hugo@hugovil.com
State	Changes Requested
Headers	show Return-Path: <linux-rtc-owner@vger.kernel.org> From: Hugo Villeneuve <hugo@hugovil.com> To: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, Hugo Villeneuve <hvilleneuve@dimonoff.com> Date: Thu, 15 Dec 2022 10:02:15 -0500 Message-Id: <20221215150214.1109074-15-hugo@hugovil.com> In-Reply-To: <20221215150214.1109074-1-hugo@hugovil.com> References: <20221215150214.1109074-1-hugo@hugovil.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131 Precedence: bulk
Series	rtc: pcf2127: add PCF2131 driver \| expand [v3,00/14] rtc: pcf2127: add PCF2131 driver [v3,01/14] rtc: pcf2127: add variant-specific configuration structure [v3,02/14] rtc: pcf2127: adapt for time/date registers at any offset [v3,03/14] rtc: pcf2127: adapt for alarm registers at any offset [v3,04/14] rtc: pcf2127: adapt for WD registers at any offset [v3,05/14] rtc: pcf2127: adapt for CLKOUT register at any offset [v3,06/14] rtc: pcf2127: add support for multiple TS functions [v3,07/14] rtc: pcf2127: add support for PCF2131 RTC [v3,08/14] rtc: pcf2127: add support for PCF2131 interrupts on output INT_A [v3,09/14] rtc: pcf2127: set PWRMNG value for PCF2131 [v3,10/14] rtc: pcf2127: read and validate PCF2131 device signature [v3,11/14] rtc: pcf2127: adapt time/date registers write sequence for PCF2131 [v3,12/14] rtc: pcf2127: support generic watchdog timing configuration [v3,13/14] rtc: pcf2127: add flag for watchdog register value read support [v3,14/14] dt-bindings: rtc: pcf2127: add PCF2131

Hugo Villeneuve Dec. 15, 2022, 3:02 p.m. UTC

From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Add support for new NXP RTC PCF2131.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Krzysztof Kozlowski Dec. 16, 2022, 1:24 p.m. UTC | #1

On 15/12/2022 16:02, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Add support for new NXP RTC PCF2131.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Bruno Thomsen Dec. 19, 2022, 9:14 a.m. UTC | #2

Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <hugo@hugovil.com>:
>
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Add support for new NXP RTC PCF2131.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..a8f8c23da4d8 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,9 @@ maintainers:
>
>  properties:
>    compatible:
> -    const: nxp,pcf2127
> +    enum:
> +      - nxp,pcf2127
> +      - nxp,pcf2131

The enum is incomplete as pcf2127_of_match struct also contains:
nxp,pcf2129
ncp,pca2129

/Bruno

>
>    reg:
>      maxItems: 1
> --
> 2.30.2
>

Hugo Villeneuve Dec. 19, 2022, 4:25 p.m. UTC | #3

On Mon, 19 Dec 2022 10:14:10 +0100
Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

> Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <hugo@hugovil.com>:
> >
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > Add support for new NXP RTC PCF2131.
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> >  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > index cde7b1675ead..a8f8c23da4d8 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -14,7 +14,9 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    const: nxp,pcf2127
> > +    enum:
> > +      - nxp,pcf2127
> > +      - nxp,pcf2131
> 
> The enum is incomplete as pcf2127_of_match struct also contains:
> nxp,pcf2129
> ncp,pca2129
> 
> /Bruno

Hi,
if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...

Hugo.


> >    reg:
> >      maxItems: 1
> > --
> > 2.30.2
> >
>

Bruno Thomsen Dec. 19, 2022, 5:18 p.m. UTC | #4

Den man. 19. dec. 2022 kl. 17.25 skrev Hugo Villeneuve <hugo@hugovil.com>:
>
> On Mon, 19 Dec 2022 10:14:10 +0100
> Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
>
> > Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <hugo@hugovil.com>:
> > >
> > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > >
> > > Add support for new NXP RTC PCF2131.
> > >
> > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > > ---
> > >  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > index cde7b1675ead..a8f8c23da4d8 100644
> > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > @@ -14,7 +14,9 @@ maintainers:
> > >
> > >  properties:
> > >    compatible:
> > > -    const: nxp,pcf2127
> > > +    enum:
> > > +      - nxp,pcf2127
> > > +      - nxp,pcf2131
> >
> > The enum is incomplete as pcf2127_of_match struct also contains:
> > nxp,pcf2129
> > ncp,pca2129
> >
> > /Bruno
>
> Hi,
> if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...
>

Correct, I just noticed while doing review.

> Hugo.
>
>
> > >    reg:
> > >      maxItems: 1
> > > --
> > > 2.30.2
> > >
> >
>
>
> --
> Hugo Villeneuve <hugo@hugovil.com>

Hugo Villeneuve Dec. 19, 2022, 6:31 p.m. UTC | #5

On Mon, 19 Dec 2022 18:18:58 +0100
Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

> Den man. 19. dec. 2022 kl. 17.25 skrev Hugo Villeneuve <hugo@hugovil.com>:
> >
> > On Mon, 19 Dec 2022 10:14:10 +0100
> > Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> >
> > > Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <hugo@hugovil.com>:
> > > >
> > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > > >
> > > > Add support for new NXP RTC PCF2131.
> > > >
> > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> > > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > index cde7b1675ead..a8f8c23da4d8 100644
> > > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > @@ -14,7 +14,9 @@ maintainers:
> > > >
> > > >  properties:
> > > >    compatible:
> > > > -    const: nxp,pcf2127
> > > > +    enum:
> > > > +      - nxp,pcf2127
> > > > +      - nxp,pcf2131
> > >
> > > The enum is incomplete as pcf2127_of_match struct also contains:
> > > nxp,pcf2129
> > > ncp,pca2129
> > >
> > > /Bruno
> >
> > Hi,
> > if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...
> >
> 
> Correct, I just noticed while doing review.

Hi,
I will send a separate patch very soon.

Thank you,
Hugo. V.


> > > >    reg:
> > > >      maxItems: 1
> > > > --
> > > > 2.30.2
> > > >
> > >
> >
> >
> > --
> > Hugo Villeneuve <hugo@hugovil.com>
>

[v3,14/14] dt-bindings: rtc: pcf2127: add PCF2131

Commit Message

Comments

Patch