| Message ID | 20221122085046.21689-1-guozihua@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: mxc_v2: Add missing clk_disable_unprepare() | expand |
On Tue, 22 Nov 2022 16:50:46 +0800, GUO Zihua wrote: > The call to clk_disable_unprepare() is left out in the error handling of > devm_rtc_allocate_device. Add it back. > > Applied, thanks! [1/1] rtc: mxc_v2: Add missing clk_disable_unprepare() commit: 5c1a0939b53b97ac090a82b9527160a5effbca87 Best regards,
diff --git a/drivers/rtc/rtc-mxc_v2.c b/drivers/rtc/rtc-mxc_v2.c index 5e0383401629..f6d2ad91ff7a 100644 --- a/drivers/rtc/rtc-mxc_v2.c +++ b/drivers/rtc/rtc-mxc_v2.c @@ -336,8 +336,10 @@ static int mxc_rtc_probe(struct platform_device *pdev) } pdata->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(pdata->rtc)) + if (IS_ERR(pdata->rtc)) { + clk_disable_unprepare(pdata->clk); return PTR_ERR(pdata->rtc); + } pdata->rtc->ops = &mxc_rtc_ops; pdata->rtc->range_max = U32_MAX;
The call to clk_disable_unprepare() is left out in the error handling of devm_rtc_allocate_device. Add it back. Fixes: 5490a1e018a4 ("rtc: mxc_v2: fix possible race condition") Signed-off-by: GUO Zihua <guozihua@huawei.com> --- drivers/rtc/rtc-mxc_v2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)